From 39c13f91004b41166b786785083e78b34df0c48f Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 1 Jun 2015 13:52:23 -0400 Subject: remove Params constructor from Utility.SafeCommand This removes a bit of complexity, and should make things faster (avoids tokenizing Params string), and probably involve less garbage collection. In a few places, it was useful to use Params to avoid needing a list, but that is easily avoided. Problems noticed while doing this conversion: * Some uses of Params "oneword" which was entirely unnecessary overhead. * A few places that built up a list of parameters with ++ and then used Params to split it! Test suite passes. --- Git/CheckAttr.hs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'Git/CheckAttr.hs') diff --git a/Git/CheckAttr.hs b/Git/CheckAttr.hs index 21eeed493..23ed22621 100644 --- a/Git/CheckAttr.hs +++ b/Git/CheckAttr.hs @@ -30,7 +30,8 @@ checkAttrStart attrs repo = do where params = [ Param "check-attr" - , Params "-z --stdin" + , Param "-z" + , Param "--stdin" ] ++ map Param attrs ++ [ Param "--" ] -- cgit v1.2.3