From c5910fd179d374f644ab3c843b243a51a7df9b24 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 19 Apr 2015 00:38:29 -0400 Subject: removed all uses of undefined from code base It's a code smell, can lead to hard to diagnose error messages. --- Git.hs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Git.hs') diff --git a/Git.hs b/Git.hs index 6e270815e..1bc789f85 100644 --- a/Git.hs +++ b/Git.hs @@ -60,7 +60,7 @@ repoLocation Repo { location = Url url } = show url repoLocation Repo { location = Local { worktree = Just dir } } = dir repoLocation Repo { location = Local { gitdir = dir } } = dir repoLocation Repo { location = LocalUnknown dir } = dir -repoLocation Repo { location = Unknown } = undefined +repoLocation Repo { location = Unknown } = error "unknown repoLocation" {- Path to a repository. For non-bare, this is the worktree, for bare, - it's the gitdir, and for URL repositories, is the path on the remote @@ -70,12 +70,12 @@ repoPath Repo { location = Url u } = unEscapeString $ uriPath u repoPath Repo { location = Local { worktree = Just d } } = d repoPath Repo { location = Local { gitdir = d } } = d repoPath Repo { location = LocalUnknown dir } = dir -repoPath Repo { location = Unknown } = undefined +repoPath Repo { location = Unknown } = error "unknown repoPath" {- Path to a local repository's .git directory. -} localGitDir :: Repo -> FilePath localGitDir Repo { location = Local { gitdir = d } } = d -localGitDir _ = undefined +localGitDir _ = error "unknown localGitDir" {- Some code needs to vary between URL and normal repos, - or bare and non-bare, these functions help with that. -} -- cgit v1.2.3