From 25f5ee379cebcc7ea4cb0b338f43f3c0e7477400 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 20 Jul 2015 14:56:57 -0400 Subject: importfeed: Look at not only permalinks, but now also guids to identify previously downloaded files. I've seen rss feeds that have no permalinks, only guids (which are sometimes in the form of permalinks, argh/sigh). I had previously avoided trusting guids to be globally unique, because my survey of rss feeds that I subscribe to shows a lot of pretty bad "guids" like "2 at http://serialpodcast.org" or even worse "oth20150401-hq". Worry was that two podcasts that are generating guids so badly, that there's no guarantee they're actually globally unique. But, I'm seeing too many url changes that result in redundant files, so let's try this. If feeds are so broken that guids overlap, they could just as well incorrectly call them permalinks too. --- Command/ImportFeed.hs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'Command/ImportFeed.hs') diff --git a/Command/ImportFeed.hs b/Command/ImportFeed.hs index 5afbb192a..46e1b6dbe 100644 --- a/Command/ImportFeed.hs +++ b/Command/ImportFeed.hs @@ -219,8 +219,7 @@ performDownload opts cache todownload = case location todownload of | otherwise = a knownitemid = case getItemId (item todownload) of - -- only when it's a permalink - Just (True, itemid) -> S.member itemid (knownitems cache) + Just (_, itemid) -> S.member itemid (knownitems cache) _ -> False rundownload url extension getter = do -- cgit v1.2.3