From 0298701d0018b0baa933761657751e0c26dc39d1 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 14 Nov 2017 15:43:40 -0400 Subject: thoughts --- ...mment_1_8e8dd79385b523502b39247135385bc4._comment | 13 +++++++++++++ ...mment_2_85c2ca68a4611e684c147fc005470fab._comment | 20 ++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_1_8e8dd79385b523502b39247135385bc4._comment create mode 100644 doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_2_85c2ca68a4611e684c147fc005470fab._comment diff --git a/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_1_8e8dd79385b523502b39247135385bc4._comment b/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_1_8e8dd79385b523502b39247135385bc4._comment new file mode 100644 index 000000000..631155c20 --- /dev/null +++ b/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_1_8e8dd79385b523502b39247135385bc4._comment @@ -0,0 +1,13 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-11-14T19:19:30Z" + content=""" +It indeed would be possible for `copy --to` to check the actual file +size when the key does not have a known size, and use that for progress. +I don't know how hard it would be. + +Note that, even if that were done, there's no guarantee that a given remote +will update progress information, and if it doesn't, --json-progress +won't result in any. So your code certianly needs to handle that case. +"""]] diff --git a/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_2_85c2ca68a4611e684c147fc005470fab._comment b/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_2_85c2ca68a4611e684c147fc005470fab._comment new file mode 100644 index 000000000..29c124845 --- /dev/null +++ b/doc/bugs/annex_copy_might_not_report_percent-progress_when_it_has_actual_key_file/comment_2_85c2ca68a4611e684c147fc005470fab._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2017-11-14T19:29:21Z" + content=""" +Messages.Progress.metered is what looks at the keySize, and when it's +not known, displays no meter. So it would need an additional Maybe FilePath +that's the file being uploaded, to look at when the keySize is not known. + +That does not seem too hard a change to make; I'm not convinced the extra +complexity is worth it, since this would only add progress for uploads, +and not for downloads. + +There is something to be said for consistency; +and if some transfers of a key have progress and others do not, +it seems the user might get confused, while if nothing does, the user +can conclude that git-annex is not able to provide progress for a key +that does not contain a size, and if they don't like that, avoid +things that generate such keys. +"""]] -- cgit v1.2.3