From 09c75c4fb8269d74ccfdfaccb36ea9f7519efdb5 Mon Sep 17 00:00:00 2001 From: Gil Date: Wed, 11 Jul 2018 19:21:48 -0700 Subject: Fix Firestore when compiled with Xcode 8.3 (#1519) * Add a travis stage that tests building Firestore with Xcode 8.3. * Simulate on a device available in Xcode 8 * Fix compile errors under Xcode 8.3.3 * Remove Firestore_SwiftTests_iOS from the Firestore_Tests_iOS Scheme I'll create a new target for this but in another PR. * Add an entry to CHANGELOG.md --- Firestore/core/test/firebase/firestore/remote/serializer_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Firestore/core/test') diff --git a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc index fb08488..4e7b7c9 100644 --- a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc +++ b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc @@ -161,7 +161,7 @@ class SerializerTest : public ::testing::Test { EXPECT_EQ(status.code(), bad_status.status().code()); } - v1beta1::Value ValueProto(nullptr_t) { + v1beta1::Value ValueProto(std::nullptr_t) { std::vector bytes = EncodeFieldValue(&serializer, FieldValue::NullValue()); v1beta1::Value proto; -- cgit v1.2.3