From 0a6618705389543191a8c44278d4c6791c84602a Mon Sep 17 00:00:00 2001
From: Gil <mcg@google.com>
Date: Mon, 9 Apr 2018 11:54:39 -0700
Subject: Add lint checking for Objective-C++ sources (#1048)

* lint.sh now lints Objective-C++ too

* cpplint checks system-style includes that should be user-style

This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.

* cpplint checks #imports and #includes

* cpplint checks that C++ system headers aren't #imported

* cpplint checks for C system headers that could be C++ system headers

* cpplint checks that Objective-C sources include their headers
---
 Firestore/core/test/firebase/firestore/util/autoid_test.cc        | 4 ++--
 Firestore/core/test/firebase/firestore/util/comparison_test.cc    | 5 ++---
 Firestore/core/test/firebase/firestore/util/secure_random_test.cc | 2 +-
 Firestore/core/test/firebase/firestore/util/string_printf_test.cc | 2 +-
 Firestore/core/test/firebase/firestore/util/string_util_test.cc   | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)

(limited to 'Firestore/core/test/firebase/firestore/util')

diff --git a/Firestore/core/test/firebase/firestore/util/autoid_test.cc b/Firestore/core/test/firebase/firestore/util/autoid_test.cc
index 079b990..808850b 100644
--- a/Firestore/core/test/firebase/firestore/util/autoid_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/autoid_test.cc
@@ -16,9 +16,9 @@
 
 #include "Firestore/core/src/firebase/firestore/util/autoid.h"
 
-#include <ctype.h>
+#include <cctype>
 
-#include <gtest/gtest.h>
+#include "gtest/gtest.h"
 
 using firebase::firestore::util::CreateAutoId;
 
diff --git a/Firestore/core/test/firebase/firestore/util/comparison_test.cc b/Firestore/core/test/firebase/firestore/util/comparison_test.cc
index ccb3011..a03aec8 100644
--- a/Firestore/core/test/firebase/firestore/util/comparison_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/comparison_test.cc
@@ -16,9 +16,8 @@
 
 #include "Firestore/core/src/firebase/firestore/util/comparison.h"
 
-#include <inttypes.h>
-#include <math.h>
-
+#include <cinttypes>
+#include <cmath>
 #include <limits>
 
 #include "Firestore/core/src/firebase/firestore/util/string_printf.h"
diff --git a/Firestore/core/test/firebase/firestore/util/secure_random_test.cc b/Firestore/core/test/firebase/firestore/util/secure_random_test.cc
index 0b7a51b..b0dfdd6 100644
--- a/Firestore/core/test/firebase/firestore/util/secure_random_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/secure_random_test.cc
@@ -16,7 +16,7 @@
 
 #include "Firestore/core/src/firebase/firestore/util/secure_random.h"
 
-#include <gtest/gtest.h>
+#include "gtest/gtest.h"
 
 using firebase::firestore::util::SecureRandom;
 
diff --git a/Firestore/core/test/firebase/firestore/util/string_printf_test.cc b/Firestore/core/test/firebase/firestore/util/string_printf_test.cc
index 085be84..14cc9c8 100644
--- a/Firestore/core/test/firebase/firestore/util/string_printf_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/string_printf_test.cc
@@ -16,7 +16,7 @@
 
 #include "Firestore/core/src/firebase/firestore/util/string_printf.h"
 
-#include <gtest/gtest.h>
+#include "gtest/gtest.h"
 
 namespace firebase {
 namespace firestore {
diff --git a/Firestore/core/test/firebase/firestore/util/string_util_test.cc b/Firestore/core/test/firebase/firestore/util/string_util_test.cc
index f94596f..a85c849 100644
--- a/Firestore/core/test/firebase/firestore/util/string_util_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/string_util_test.cc
@@ -16,7 +16,7 @@
 
 #include "Firestore/core/src/firebase/firestore/util/string_util.h"
 
-#include <gtest/gtest.h>
+#include "gtest/gtest.h"
 
 namespace firebase {
 namespace firestore {
-- 
cgit v1.2.3