From 22c226af3f5570514d3d13d82a399577ecd7d280 Mon Sep 17 00:00:00 2001 From: Konstantin Varlamov Date: Tue, 27 Mar 2018 11:50:03 -0400 Subject: C++ migration: make Timestamp class a part of public API (#944) * move Timestamp from model/ to the root directory; * move Timestamp to top-level firebase namespace and update all references; * add conversions to and from native date types; * add a specialization of std::hash; * add comments to public member functions; * rename nanos -> nanoseconds; * add public headers, including Timestamp, to CMake; * increase test coverage. --- .../test/firebase/firestore/model/CMakeLists.txt | 1 - .../firebase/firestore/model/timestamp_test.cc | 49 ---------------------- 2 files changed, 50 deletions(-) delete mode 100644 Firestore/core/test/firebase/firestore/model/timestamp_test.cc (limited to 'Firestore/core/test/firebase/firestore/model') diff --git a/Firestore/core/test/firebase/firestore/model/CMakeLists.txt b/Firestore/core/test/firebase/firestore/model/CMakeLists.txt index 0d581bc..2c2281f 100644 --- a/Firestore/core/test/firebase/firestore/model/CMakeLists.txt +++ b/Firestore/core/test/firebase/firestore/model/CMakeLists.txt @@ -24,7 +24,6 @@ cc_test( no_document_test.cc resource_path_test.cc snapshot_version_test.cc - timestamp_test.cc DEPENDS firebase_firestore_model ) diff --git a/Firestore/core/test/firebase/firestore/model/timestamp_test.cc b/Firestore/core/test/firebase/firestore/model/timestamp_test.cc deleted file mode 100644 index 55ee378..0000000 --- a/Firestore/core/test/firebase/firestore/model/timestamp_test.cc +++ /dev/null @@ -1,49 +0,0 @@ -/* - * Copyright 2018 Google - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#include "Firestore/core/src/firebase/firestore/model/timestamp.h" - -#include - -#include "gtest/gtest.h" - -namespace firebase { -namespace firestore { -namespace model { - -TEST(Timestamp, Getter) { - const Timestamp timestamp_zero; - EXPECT_EQ(0, timestamp_zero.seconds()); - EXPECT_EQ(0, timestamp_zero.nanos()); - - const Timestamp timestamp(100, 200); - EXPECT_EQ(100, timestamp.seconds()); - EXPECT_EQ(200, timestamp.nanos()); - - const Timestamp timestamp_now = Timestamp::Now(); - EXPECT_LT(0, timestamp_now.seconds()); - EXPECT_LE(0, timestamp_now.nanos()); -} - -TEST(Timestamp, Comparison) { - EXPECT_TRUE(Timestamp() < Timestamp(1, 2)); - EXPECT_TRUE(Timestamp(1, 2) < Timestamp(2, 1)); - EXPECT_TRUE(Timestamp(2, 1) < Timestamp(2, 2)); -} - -} // namespace model -} // namespace firestore -} // namespace firebase -- cgit v1.2.3