From b3d5767ce6cbba7ae59651e8ffeab7d45df59f8b Mon Sep 17 00:00:00 2001 From: rsgowman Date: Mon, 14 May 2018 09:57:27 -0400 Subject: Trivial/noop fix to the serializer (#1264) Was using google_firestore_v1beta1_MapValue_FieldsEntry_key_tag to tag the key/value pair. (But that tag should be used for the *key* of the key/value pair, not the pair itself.) Switched to using google_firestore_v1beta1_MapValue_fields_tag. This previously worked anyways by coincidence. These two values happen to be the same. (But it caused me all sorts of confusion as I adapted this for Document contents.) --- Firestore/core/src/firebase/firestore/remote/serializer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Firestore/core/src') diff --git a/Firestore/core/src/firebase/firestore/remote/serializer.cc b/Firestore/core/src/firebase/firestore/remote/serializer.cc index 7aec38b..0a1c168 100644 --- a/Firestore/core/src/firebase/firestore/remote/serializer.cc +++ b/Firestore/core/src/firebase/firestore/remote/serializer.cc @@ -281,8 +281,8 @@ void EncodeObject(Writer* writer, const ObjectValue& object_value) { return writer->WriteNestedMessage([&object_value](Writer* writer) { // Write each FieldsEntry (i.e. key-value pair.) for (const auto& kv : object_value.internal_value) { - writer->WriteTag({PB_WT_STRING, - google_firestore_v1beta1_MapValue_FieldsEntry_key_tag}); + writer->WriteTag( + {PB_WT_STRING, google_firestore_v1beta1_MapValue_fields_tag}); writer->WriteNestedMessage( [&kv](Writer* writer) { return EncodeFieldsEntry(writer, kv); }); } -- cgit v1.2.3