From adcaa59e433949bfb4236fa65bfec9b870cd2920 Mon Sep 17 00:00:00 2001 From: rsgowman Date: Thu, 5 Apr 2018 17:28:33 -0400 Subject: Fix build breakage on linux (#997) --- Firestore/core/src/firebase/firestore/immutable/sorted_map.h | 4 ++++ Firestore/core/src/firebase/firestore/util/firebase_assert.h | 5 +++++ 2 files changed, 9 insertions(+) (limited to 'Firestore/core/src/firebase/firestore') diff --git a/Firestore/core/src/firebase/firestore/immutable/sorted_map.h b/Firestore/core/src/firebase/firestore/immutable/sorted_map.h index 5ed16b3..ef6f54e 100644 --- a/Firestore/core/src/firebase/firestore/immutable/sorted_map.h +++ b/Firestore/core/src/firebase/firestore/immutable/sorted_map.h @@ -144,6 +144,7 @@ class SortedMap : public impl::SortedMapBase { case Tag::Tree: return SortedMap{tree_.insert(key, value)}; } + FIREBASE_UNREACHABLE(); } /** @@ -159,6 +160,7 @@ class SortedMap : public impl::SortedMapBase { case Tag::Tree: return SortedMap{tree_.erase(key)}; } + FIREBASE_UNREACHABLE(); } /** Returns true if the map contains no elements. */ @@ -169,6 +171,7 @@ class SortedMap : public impl::SortedMapBase { case Tag::Tree: return tree_.empty(); } + FIREBASE_UNREACHABLE(); } /** Returns the number of items in this map. */ @@ -179,6 +182,7 @@ class SortedMap : public impl::SortedMapBase { case Tag::Tree: return tree_.size(); } + FIREBASE_UNREACHABLE(); } private: diff --git a/Firestore/core/src/firebase/firestore/util/firebase_assert.h b/Firestore/core/src/firebase/firestore/util/firebase_assert.h index 20c8429..6bc0dee 100644 --- a/Firestore/core/src/firebase/firestore/util/firebase_assert.h +++ b/Firestore/core/src/firebase/firestore/util/firebase_assert.h @@ -103,6 +103,11 @@ FIREBASE_DEV_ASSERT_MESSAGE_WITH_EXPRESSION(expression, expression, \ __VA_ARGS__) +// Indicates an area of the code that cannot be reached (except possibly due to +// undefined behaviour or other similar badness). The only reasonable thing to +// do in these cases is to immediately abort. +#define FIREBASE_UNREACHABLE() abort() + namespace firebase { namespace firestore { namespace util { -- cgit v1.2.3