From 35de3c54d543d7be16fdcae9205ffe247f2917a7 Mon Sep 17 00:00:00 2001 From: rsgowman Date: Thu, 15 Mar 2018 10:10:22 -0400 Subject: Move creation of pb_ostream_t's into Writer (#920) * Move creation of pb_ostream_t's into Writer Writer now owns these structs * Writer::FromBuffer -> Writer::Wrap * add todo for possible future simplification. --- Firestore/core/src/firebase/firestore/remote/serializer.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'Firestore/core/src/firebase/firestore/remote/serializer.h') diff --git a/Firestore/core/src/firebase/firestore/remote/serializer.h b/Firestore/core/src/firebase/firestore/remote/serializer.h index 635ffc3..10cacbc 100644 --- a/Firestore/core/src/firebase/firestore/remote/serializer.h +++ b/Firestore/core/src/firebase/firestore/remote/serializer.h @@ -67,6 +67,9 @@ class Serializer { * appended to this vector. */ // TODO(rsgowman): error handling, incl return code. + // TODO(rsgowman): If we never support any output except to a vector, it may + // make sense to have Serializer own the vector and provide an accessor rather + // than asking the user to create it first. static void EncodeFieldValue( const firebase::firestore::model::FieldValue& field_value, std::vector* out_bytes); -- cgit v1.2.3