From 8876622b6fcebc21672bc263666b858b7e152b45 Mon Sep 17 00:00:00 2001 From: Gil Date: Thu, 12 Apr 2018 14:54:53 -0700 Subject: Add clang-tidy checks for Firestore (#1078) * Add a .clang-tidy configuration for Firestore C++ * Fix clang-tidy warnings * typedef -> using * const ref + rvalue ref -> pass by value * NULL -> nullptr * remove useless default initializations * remove useless const value-type parameter declarations (definitions can still use them) * use auto instead of repeating types in a cast * Fix typos * Address use of static method through instance warnings * Address use after move warnings --- Firestore/core/src/firebase/firestore/auth/user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Firestore/core/src/firebase/firestore/auth/user.h') diff --git a/Firestore/core/src/firebase/firestore/auth/user.h b/Firestore/core/src/firebase/firestore/auth/user.h index 3918c61..cc030cc 100644 --- a/Firestore/core/src/firebase/firestore/auth/user.h +++ b/Firestore/core/src/firebase/firestore/auth/user.h @@ -41,7 +41,7 @@ class User { User(); /** Construct an authenticated user with the given UID. */ - explicit User(const absl::string_view uid); + explicit User(absl::string_view uid); const std::string& uid() const { return uid_; -- cgit v1.2.3