From 8876622b6fcebc21672bc263666b858b7e152b45 Mon Sep 17 00:00:00 2001 From: Gil Date: Thu, 12 Apr 2018 14:54:53 -0700 Subject: Add clang-tidy checks for Firestore (#1078) * Add a .clang-tidy configuration for Firestore C++ * Fix clang-tidy warnings * typedef -> using * const ref + rvalue ref -> pass by value * NULL -> nullptr * remove useless default initializations * remove useless const value-type parameter declarations (definitions can still use them) * use auto instead of repeating types in a cast * Fix typos * Address use of static method through instance warnings * Address use after move warnings --- Firestore/core/src/firebase/firestore/auth/token.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Firestore/core/src/firebase/firestore/auth/token.h') diff --git a/Firestore/core/src/firebase/firestore/auth/token.h b/Firestore/core/src/firebase/firestore/auth/token.h index 4b2f3aa..56084f8 100644 --- a/Firestore/core/src/firebase/firestore/auth/token.h +++ b/Firestore/core/src/firebase/firestore/auth/token.h @@ -42,7 +42,7 @@ namespace auth { // TODO(zxu123): Make this support token-type for desktop workflow. class Token { public: - Token(const absl::string_view token, const User& user); + Token(absl::string_view token, const User& user); /** The actual raw token. */ const std::string& token() const { -- cgit v1.2.3