From 8876622b6fcebc21672bc263666b858b7e152b45 Mon Sep 17 00:00:00 2001 From: Gil Date: Thu, 12 Apr 2018 14:54:53 -0700 Subject: Add clang-tidy checks for Firestore (#1078) * Add a .clang-tidy configuration for Firestore C++ * Fix clang-tidy warnings * typedef -> using * const ref + rvalue ref -> pass by value * NULL -> nullptr * remove useless default initializations * remove useless const value-type parameter declarations (definitions can still use them) * use auto instead of repeating types in a cast * Fix typos * Address use of static method through instance warnings * Address use after move warnings --- Firestore/core/include/firebase/firestore/document_reference.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Firestore/core/include') diff --git a/Firestore/core/include/firebase/firestore/document_reference.h b/Firestore/core/include/firebase/firestore/document_reference.h index 58310b5..d295188 100644 --- a/Firestore/core/include/firebase/firestore/document_reference.h +++ b/Firestore/core/include/firebase/firestore/document_reference.h @@ -16,7 +16,7 @@ // TODO(rsgowman): This file isn't intended to be used just yet. It's just an // outline of what the API might eventually look like. Most of this was -// shamelessly stolen and modified from rtdb's header file, melded with the +// shamelessly stolen and modified from RTDB's header file, melded with the // (java) firestore api. #ifndef FIRESTORE_CORE_INCLUDE_FIREBASE_FIRESTORE_DOCUMENT_REFERENCE_H_ @@ -36,7 +36,7 @@ // here so we don't forget to mention this during the API review, and should be // removed once this note has migrated to the API review doc. -// TODO(rsgowman): replace these forward decl's with appropriate includes (once +// TODO(rsgowman): replace these forward decls with appropriate includes (once // they exist) namespace firebase { class App; @@ -47,7 +47,7 @@ class Future; namespace firebase { namespace firestore { -// TODO(rsgowman): replace these forward decl's with appropriate includes (once +// TODO(rsgowman): replace these forward decls with appropriate includes (once // they exist) class FieldValue; class DocumentSnapshot; @@ -361,7 +361,7 @@ namespace std { // C++ style guide. But we think this is probably ok in this case since: // a) It's the standard way of doing this outside of Google (as the style guide // itself points out), and -// b) This has a straightfoward hash function anyway (just hash the path) so I +// b) This has a straightforward hash function anyway (just hash the path) so I // don't think the concerns in the style guide are going to bite us. // // Raise this concern during the API review. -- cgit v1.2.3