From 0a6618705389543191a8c44278d4c6791c84602a Mon Sep 17 00:00:00 2001
From: Gil <mcg@google.com>
Date: Mon, 9 Apr 2018 11:54:39 -0700
Subject: Add lint checking for Objective-C++ sources (#1048)

* lint.sh now lints Objective-C++ too

* cpplint checks system-style includes that should be user-style

This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.

* cpplint checks #imports and #includes

* cpplint checks that C++ system headers aren't #imported

* cpplint checks for C system headers that could be C++ system headers

* cpplint checks that Objective-C sources include their headers
---
 Firestore/Source/Model/FSTDocumentKey.h  | 1 +
 Firestore/Source/Model/FSTDocumentKey.mm | 1 +
 Firestore/Source/Model/FSTFieldValue.mm  | 4 +---
 3 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'Firestore/Source/Model')

diff --git a/Firestore/Source/Model/FSTDocumentKey.h b/Firestore/Source/Model/FSTDocumentKey.h
index dbcff2c..a403117 100644
--- a/Firestore/Source/Model/FSTDocumentKey.h
+++ b/Firestore/Source/Model/FSTDocumentKey.h
@@ -17,6 +17,7 @@
 #import <Foundation/Foundation.h>
 
 #include <initializer_list>
+#include <string>
 
 #include "Firestore/core/src/firebase/firestore/model/resource_path.h"
 
diff --git a/Firestore/Source/Model/FSTDocumentKey.mm b/Firestore/Source/Model/FSTDocumentKey.mm
index cbe9c89..679d7a6 100644
--- a/Firestore/Source/Model/FSTDocumentKey.mm
+++ b/Firestore/Source/Model/FSTDocumentKey.mm
@@ -16,6 +16,7 @@
 
 #import "Firestore/Source/Model/FSTDocumentKey.h"
 
+#include <string>
 #include <utility>
 
 #import "Firestore/Source/Core/FSTFirestoreClient.h"
diff --git a/Firestore/Source/Model/FSTFieldValue.mm b/Firestore/Source/Model/FSTFieldValue.mm
index 80bd11f..0d7c649 100644
--- a/Firestore/Source/Model/FSTFieldValue.mm
+++ b/Firestore/Source/Model/FSTFieldValue.mm
@@ -18,9 +18,6 @@
 
 #import "FIRTimestamp.h"
 
-#include "Firestore/core/src/firebase/firestore/util/comparison.h"
-#include "Firestore/core/src/firebase/firestore/util/string_apple.h"
-
 #import "Firestore/Source/API/FIRGeoPoint+Internal.h"
 #import "Firestore/Source/API/FIRSnapshotOptions+Internal.h"
 #import "Firestore/Source/Model/FSTDocumentKey.h"
@@ -29,6 +26,7 @@
 
 #include "Firestore/core/src/firebase/firestore/model/database_id.h"
 #include "Firestore/core/src/firebase/firestore/model/field_path.h"
+#include "Firestore/core/src/firebase/firestore/util/comparison.h"
 #include "Firestore/core/src/firebase/firestore/util/string_apple.h"
 
 namespace util = firebase::firestore::util;
-- 
cgit v1.2.3