From 4afaafdc770612185c4e11d3f09226ce168462a5 Mon Sep 17 00:00:00 2001 From: Greg Soltis Date: Thu, 22 Mar 2018 15:45:05 -0700 Subject: Change write groups to use transactions (#912) * Start work on leveldb transactions * Style * Working API. Not plumbed in yet * Move files into correct place * Wrangling file locations and associations * Tests pass * Add some comments * style * Fix copyright * Rewrite iterator internals to handle deletion-while-iterating. Also add tests for same * Switch to strings instead of slices * Style * More style fixes * Start switching writegroup over * Swap out write group tracking for transaction usage * Style * Response to feedback before updating docs * Style * Add comment * Initialize version_ * Satisfy the linter * Start switching writegroup over * Swap out write group tracking for transaction usage * Style * Checkpoint before implementing BatchDescription * Style * Everything passing * Drop unused function * Style * Renaming * Style * Add log line * Style * Add debug log line for commits, drop unused BatchDescription --- Firestore/Source/Local/FSTLevelDBQueryCache.h | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'Firestore/Source/Local/FSTLevelDBQueryCache.h') diff --git a/Firestore/Source/Local/FSTLevelDBQueryCache.h b/Firestore/Source/Local/FSTLevelDBQueryCache.h index 1f6fbd4..d955b02 100644 --- a/Firestore/Source/Local/FSTLevelDBQueryCache.h +++ b/Firestore/Source/Local/FSTLevelDBQueryCache.h @@ -19,6 +19,7 @@ #include #import "Firestore/Source/Local/FSTQueryCache.h" +#include "Firestore/core/src/firebase/firestore/local/leveldb_transaction.h" #include "leveldb/db.h" @class FSTLocalSerializer; @@ -32,9 +33,16 @@ NS_ASSUME_NONNULL_BEGIN /** * Retrieves the global singleton metadata row from the given database, if it exists. + * TODO(gsoltis): remove this method once fully ported to transactions. */ + (nullable FSTPBTargetGlobal *)readTargetMetadataFromDB:(std::shared_ptr)db; +/** + * Retrieves the global singleton metadata row using the given transaction, if it exists. + */ ++ (nullable FSTPBTargetGlobal *)readTargetMetadataWithTransaction: + (firebase::firestore::local::LevelDbTransaction *)transaction; + - (instancetype)init NS_UNAVAILABLE; /** The garbage collector to notify about potential garbage keys. */ -- cgit v1.2.3