From f122cf7ce802972bd2fea45acac3deae2affcafa Mon Sep 17 00:00:00 2001 From: Michael Lehenbauer Date: Mon, 12 Mar 2018 11:53:26 -0700 Subject: Fix MutationQueue issue resulting in re-sending acknowledged writes. (#909) Port of: https://github.com/firebase/firebase-js-sdk/pull/559 Should address #772 once released. getNextMutationBatchAfterBatchId() was not respecting highestAcknowledgedBatchId and therefore we were resending writes after the network was disabled / re-enabled. --- Firestore/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) (limited to 'Firestore/CHANGELOG.md') diff --git a/Firestore/CHANGELOG.md b/Firestore/CHANGELOG.md index 71b61ef..e1ae4dc 100644 --- a/Firestore/CHANGELOG.md +++ b/Firestore/CHANGELOG.md @@ -3,6 +3,9 @@ neither succeeds nor fails within 10 seconds, the SDK will consider itself "offline", causing getDocument() calls to resolve with cached results, rather than continuing to wait. +- [fixed] Fixed a potential race condition after calling `enableNetwork()` that + could result in a "Mutation batchIDs must be acknowledged in order" assertion + crash. # v0.10.3 - [fixed] Fixed a regression in the 4.10.0 Firebase iOS SDK release that -- cgit v1.2.3