From 4ec5f00b1dec8220c1e458d852eecd602dd56b8f Mon Sep 17 00:00:00 2001 From: rsgowman Date: Thu, 30 Nov 2017 13:41:26 -0500 Subject: Fix StringView to properly convert NSStrings (#509) NSStrings are utf16, so NSString::length returns the number of utf16 characters present in the string. When the string is entirely made up of US-ASCII characters, everything's fine. But when characters requiring 16 bits are present, the size calculations were incorrect. Fixed by calculating the length based on the destination character set (i.e. UTF8). --- Firestore/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) (limited to 'Firestore/CHANGELOG.md') diff --git a/Firestore/CHANGELOG.md b/Firestore/CHANGELOG.md index 884af45..f1cd832 100644 --- a/Firestore/CHANGELOG.md +++ b/Firestore/CHANGELOG.md @@ -1,5 +1,7 @@ # Unreleased - [changed] Firestore no longer has a direct dependency on FirebaseAuth. +- [fixed] Fixed a crash when using path names with international characters + with persistence enabled. # v0.9.3 - [changed] Improved performance loading documents matching a query. -- cgit v1.2.3