From dd5c3c41b91a8642807303c99ba0c39e56f11e25 Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Fri, 25 May 2018 09:00:03 -0400 Subject: Temporary fix for Messaging's data collection bit (#1334) (#1336) * Temporary fix for Messaging's data collection bit This ensures that existing behavior still works - InstanceID can sometimes fetch stored values before `FirebaseApp.configure()` is called, causing the global flag to be `NO`. Will file an issue shortly. * Remove extra whitespaces Thanks, GitHub editor. * Fix method being called --- Firebase/Messaging/FIRMessaging.m | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'Firebase') diff --git a/Firebase/Messaging/FIRMessaging.m b/Firebase/Messaging/FIRMessaging.m index d5e0a01..3c1c730 100644 --- a/Firebase/Messaging/FIRMessaging.m +++ b/Firebase/Messaging/FIRMessaging.m @@ -173,6 +173,10 @@ NSString *const kFIRMessagingPlistAutoInitEnabled = _loggedMessageIDs = [NSMutableSet set]; _instanceID = instanceID; _messagingUserDefaults = defaults; + + // TODO: Remove this once the race condition with FIRApp configuring and InstanceID + // is fixed. This must be fixed before Core's flag becomes public. + _globalAutomaticDataCollectionEnabled = YES; } return self; } -- cgit v1.2.3