From d5012f3fec1ba54f77aa703a09872ffbf108e445 Mon Sep 17 00:00:00 2001 From: Benoit St-Pierre Date: Thu, 11 Jan 2018 12:30:04 -0500 Subject: Version bump for 4.8.1 Release Updated the version numbers of pods which are being released in 4.8.1 --- Firebase/Core/FIROptions.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Firebase') diff --git a/Firebase/Core/FIROptions.m b/Firebase/Core/FIROptions.m index b60ccdd..aecb95d 100644 --- a/Firebase/Core/FIROptions.m +++ b/Firebase/Core/FIROptions.m @@ -42,7 +42,7 @@ NSString *const kFIRIsSignInEnabled = @"IS_SIGNIN_ENABLED"; NSString *const kFIRLibraryVersionID = @"4" // Major version (one or more digits) @"00" // Minor version (exactly 2 digits) - @"13" // Build number (exactly 2 digits) + @"14" // Build number (exactly 2 digits) @"000"; // Fixed "000" // Plist file name. NSString *const kServiceInfoFileName = @"GoogleService-Info"; -- cgit v1.2.3 From a8aec7827122b1d66d799f71464caf750c3a392b Mon Sep 17 00:00:00 2001 From: Benoit St-Pierre Date: Thu, 11 Jan 2018 13:06:28 -0500 Subject: Update from master Picking up a few last-minute changes to CHANGELOGs and tests for 4.8.1 release. --- Firebase/Auth/CHANGELOG.md | 5 +++++ Firestore/CHANGELOG.md | 6 +++++- .../Example/Tests/Integration/API/FIRQueryTests.m | 23 ++++++++++++++++++++++ .../Example/Tests/Util/FSTIntegrationTestCase.mm | 2 +- Firestore/Source/Local/FSTLocalDocumentsView.m | 4 ++-- 5 files changed, 36 insertions(+), 4 deletions(-) (limited to 'Firebase') diff --git a/Firebase/Auth/CHANGELOG.md b/Firebase/Auth/CHANGELOG.md index d464cd6..176ae3b 100644 --- a/Firebase/Auth/CHANGELOG.md +++ b/Firebase/Auth/CHANGELOG.md @@ -1,3 +1,8 @@ +# v4.4.1 +- Fixes bug where the FIRAuthResult object returned following a Phone Number authentication + always contained a nil FIRAdditionalUserInfo object. Now the FIRAdditionalUserInfo object is + never nil and its newUser field is populated correctly. + # v4.4.0 - Adds new APIs which return an AuthDataResult object after successfully creating an Email/Password user, signing in anonymously, signing in with Email/Password and signing diff --git a/Firestore/CHANGELOG.md b/Firestore/CHANGELOG.md index 59858e6..31a477c 100644 --- a/Firestore/CHANGELOG.md +++ b/Firestore/CHANGELOG.md @@ -1,4 +1,6 @@ -# Unreleased (firestore-api-changes) +# Unreleased + +# v0.10.0 - [changed] Removed the includeMetadataChanges property in FIRDocumentListenOptions to avoid confusion with the factory method of the same name. - [changed] Added a commit method that takes no completion handler to FIRWriteBatch. @@ -13,6 +15,8 @@ `true` if the SDK loses its connection to the backend. A new event with `snapshot.metadata.isFromCache` set to false will be raised once the connection is restored and the query is in sync with the backend again. +- [fixed] Multiple offline mutations now properly reflected in retrieved + documents. Previously, only the last mutation would be visible. (#643) # v0.9.4 - [changed] Firestore no longer has a direct dependency on FirebaseAuth. diff --git a/Firestore/Example/Tests/Integration/API/FIRQueryTests.m b/Firestore/Example/Tests/Integration/API/FIRQueryTests.m index 831c897..58f57bc 100644 --- a/Firestore/Example/Tests/Integration/API/FIRQueryTests.m +++ b/Firestore/Example/Tests/Integration/API/FIRQueryTests.m @@ -275,4 +275,27 @@ [registration remove]; } +- (void)testCanHaveMultipleMutationsWhileOffline { + FIRCollectionReference *col = [self collectionRef]; + + // set a few docs to known values + NSDictionary *initialDocs = + @{ @"doc1" : @{@"key1" : @"value1"}, + @"doc2" : @{@"key2" : @"value2"} }; + [self writeAllDocuments:initialDocs toCollection:col]; + + // go offline for the rest of this test + [self disableNetwork]; + + // apply *multiple* mutations while offline + [[col documentWithPath:@"doc1"] setData:@{@"key1b" : @"value1b"}]; + [[col documentWithPath:@"doc2"] setData:@{@"key2b" : @"value2b"}]; + + FIRQuerySnapshot *result = [self readDocumentSetForRef:col]; + XCTAssertEqualObjects(FIRQuerySnapshotGetData(result), (@[ + @{@"key1b" : @"value1b"}, + @{@"key2b" : @"value2b"}, + ])); +} + @end diff --git a/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm b/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm index 839e4a5..ef15056 100644 --- a/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm +++ b/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm @@ -18,7 +18,6 @@ #import #import -#import #import #import @@ -26,6 +25,7 @@ #import "Firestore/Source/API/FIRFirestore+Internal.h" #import "Firestore/Source/Auth/FSTEmptyCredentialsProvider.h" +#import "Firestore/Source/Core/FSTFirestoreClient.h" #import "Firestore/Source/Local/FSTLevelDB.h" #import "Firestore/Source/Model/FSTDatabaseID.h" #import "Firestore/Source/Util/FSTDispatchQueue.h" diff --git a/Firestore/Source/Local/FSTLocalDocumentsView.m b/Firestore/Source/Local/FSTLocalDocumentsView.m index a6734c4..0e88958 100644 --- a/Firestore/Source/Local/FSTLocalDocumentsView.m +++ b/Firestore/Source/Local/FSTLocalDocumentsView.m @@ -167,9 +167,9 @@ NS_ASSUME_NONNULL_BEGIN BOOL *stop) { FSTMaybeDocument *mutatedDoc = [self localDocument:remoteDocument key:key]; if ([mutatedDoc isKindOfClass:[FSTDeletedDocument class]]) { - result = [documents dictionaryByRemovingObjectForKey:key]; + result = [result dictionaryByRemovingObjectForKey:key]; } else if ([mutatedDoc isKindOfClass:[FSTDocument class]]) { - result = [documents dictionaryBySettingObject:(FSTDocument *)mutatedDoc forKey:key]; + result = [result dictionaryBySettingObject:(FSTDocument *)mutatedDoc forKey:key]; } else { FSTFail(@"Unknown document: %@", mutatedDoc); } -- cgit v1.2.3 From b36d92f2b5d58abcf96a2cbd63e0f1e04587b1b4 Mon Sep 17 00:00:00 2001 From: Benoit St-Pierre Date: Thu, 11 Jan 2018 13:40:16 -0500 Subject: Update Core info for M21.1 Update missing version bump for M21.1 for FirebaseCore. --- Firebase/Core/CHANGELOG.md | 2 +- FirebaseCore.podspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'Firebase') diff --git a/Firebase/Core/CHANGELOG.md b/Firebase/Core/CHANGELOG.md index 18e956d..7051167 100644 --- a/Firebase/Core/CHANGELOG.md +++ b/Firebase/Core/CHANGELOG.md @@ -1,4 +1,4 @@ -# Unreleased +# v4.0.14 -- M21.1 - [changed] Removed AppKit dependency for community macOS build. # 2017-11-30 -- v4.0.12 -- M20.2 diff --git a/FirebaseCore.podspec b/FirebaseCore.podspec index 854815e..3c583cf 100644 --- a/FirebaseCore.podspec +++ b/FirebaseCore.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'FirebaseCore' - s.version = '4.0.13' + s.version = '4.0.14' s.summary = 'Firebase Core for iOS' s.description = <<-DESC -- cgit v1.2.3