From 81709006e65a648fb529f3081224ea749a95ccc6 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Fri, 13 Apr 2018 14:07:56 -0700 Subject: More comments --- Firebase/Storage/CHANGELOG.md | 2 +- Firebase/Storage/FIRStorageGetDownloadURLTask.m | 2 +- Firebase/Storage/FIRStorageUpdateMetadataTask.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'Firebase') diff --git a/Firebase/Storage/CHANGELOG.md b/Firebase/Storage/CHANGELOG.md index a48c3c5..135de40 100644 --- a/Firebase/Storage/CHANGELOG.md +++ b/Firebase/Storage/CHANGELOG.md @@ -1,6 +1,6 @@ # v3.0.0 - [removed] Removed `downloadURLs` property on `StorageMetadata`. Use `StorageReference.downloadURL(completion:)` to obtain a current download URL. -- [changed] The `maxOperationRetryTime` timeout now applies to calls to `StorageReference.getMetadata(completion:)`. +- [changed] The `maxOperationRetryTime` timeout now applies to calls to `StorageReference.getMetadata(completion:)` and `StorageReference.updateMetadata(completion:)`. These calls previously used the `maxDownloadRetryTime` and `maxUploadRetryTime` timeouts. # v2.2.0 - [changed] Deprecated `downloadURLs` property on `StorageMetadata`. Use `StorageReference.downloadURL(completion:)` to obtain a current download URL. diff --git a/Firebase/Storage/FIRStorageGetDownloadURLTask.m b/Firebase/Storage/FIRStorageGetDownloadURLTask.m index c4e0035..02d202e 100644 --- a/Firebase/Storage/FIRStorageGetDownloadURLTask.m +++ b/Firebase/Storage/FIRStorageGetDownloadURLTask.m @@ -93,7 +93,7 @@ [FIRStorageGetDownloadURLTask downloadURLFromMetadataDictionary:responseDictionary]; if (!downloadURL) { self.error = - [FIRStorageErrors errorWithCustomMessage:@"Failed to retrieve a download URL"]; + [FIRStorageErrors errorWithCustomMessage:@"Failed to retrieve a download URL."]; } } else { self.error = [FIRStorageErrors errorWithInvalidRequest:data]; diff --git a/Firebase/Storage/FIRStorageUpdateMetadataTask.m b/Firebase/Storage/FIRStorageUpdateMetadataTask.m index d866329..cea4e7d 100644 --- a/Firebase/Storage/FIRStorageUpdateMetadataTask.m +++ b/Firebase/Storage/FIRStorageUpdateMetadataTask.m @@ -48,7 +48,7 @@ NSDictionary *updateDictionary = [_updateMetadata updatedMetadata]; NSData *updateData = [NSData frs_dataFromJSONDictionary:updateDictionary]; request.HTTPMethod = @"PATCH"; - request.timeoutInterval = self.reference.storage.maxUploadRetryTime; + request.timeoutInterval = self.reference.storage.maxOperationRetryTime; request.HTTPBody = updateData; NSString *typeString = @"application/json; charset=UTF-8"; [request setValue:typeString forHTTPHeaderField:@"Content-Type"]; -- cgit v1.2.3