From 4a22dc2a180eb0f7a6b19ff79cadd71f82cd7f12 Mon Sep 17 00:00:00 2001
From: Sebastian Schmidt <mrschmidt@google.com>
Date: Wed, 26 Jul 2017 13:50:34 -0700
Subject: Purge persistence cache if we can't load from it (#153)

* Purge persistence cache if we can't load from it

* Adding unit test

* Review comments
---
 .../Database/Persistence/FLevelDBStorageEngine.h   |  2 ++
 .../Database/Persistence/FLevelDBStorageEngine.m   | 40 +++++++++++++++-------
 2 files changed, 30 insertions(+), 12 deletions(-)

(limited to 'Firebase')

diff --git a/Firebase/Database/Persistence/FLevelDBStorageEngine.h b/Firebase/Database/Persistence/FLevelDBStorageEngine.h
index 059a071..84f3864 100644
--- a/Firebase/Database/Persistence/FLevelDBStorageEngine.h
+++ b/Firebase/Database/Persistence/FLevelDBStorageEngine.h
@@ -29,6 +29,8 @@
 
 @interface FLevelDBStorageEngine : NSObject<FStorageEngine>
 
++ (NSString *) firebaseDir;
+
 - (id)initWithPath:(NSString *)path;
 
 - (void)runLegacyMigration:(FRepoInfo *)info;
diff --git a/Firebase/Database/Persistence/FLevelDBStorageEngine.m b/Firebase/Database/Persistence/FLevelDBStorageEngine.m
index 22d67ad..3a63319 100644
--- a/Firebase/Database/Persistence/FLevelDBStorageEngine.m
+++ b/Firebase/Database/Persistence/FLevelDBStorageEngine.m
@@ -180,17 +180,21 @@ static NSString* trackedQueryKeysKey(NSUInteger trackedQueryId, NSString *key) {
     self.writesDB = [self createDB:kFWritesDBPath];
 }
 
+- (void)purgeDatabase:(NSString*) dbPath {
+    NSString *path = [self.basePath stringByAppendingPathComponent:dbPath];
+    NSError *error;
+    FFWarn(@"I-RDB076009", @"Deleting database at path %@", path);
+    BOOL success = [[NSFileManager defaultManager] removeItemAtPath:path error:&error];
+    if (!success) {
+        [NSException raise:NSInternalInconsistencyException format:@"Failed to delete database files: %@", error];
+    }
+}
+
 - (void)purgeEverything {
     [self close];
     [@[kFServerDBPath, kFWritesDBPath]
      enumerateObjectsUsingBlock:^(NSString *dbPath, NSUInteger idx, BOOL *stop) {
-         NSString *path = [self.basePath stringByAppendingPathComponent:dbPath];
-         NSError *error;
-         FFDebug(@"I-RDB076009", @"Deleting database at path %@", path);
-         BOOL success = [[NSFileManager defaultManager] removeItemAtPath:path error:&error];
-         if (!success) {
-             [NSException raise:NSInternalInconsistencyException format:@"Failed to delete database files: %@", error];
-         }
+         [self purgeDatabase:dbPath];
     }];
 
     [self openDatabases];
@@ -216,14 +220,26 @@ static NSString* trackedQueryKeysKey(NSUInteger trackedQueryId, NSString *key) {
     #endif
 }
 
-- (APLevelDB *)createDB:(NSString *)name {
+- (APLevelDB *)createDB:(NSString *)dbName {
     NSError *err = nil;
-    NSString *path = [self.basePath stringByAppendingPathComponent:name];
+    NSString *path = [self.basePath stringByAppendingPathComponent:dbName];
     APLevelDB *db = [APLevelDB levelDBWithPath:path error:&err];
-    if(err) {
-        NSString *reason = [NSString stringWithFormat:@"Error initializing persistence: %@", [err description]];
-        @throw [NSException exceptionWithName:@"FirebaseDatabasePersistenceFailure" reason:reason userInfo:nil];
+
+    if (err) {
+        FFWarn(@"I-RDB076036", @"Failed to read database persistence file '%@': %@",
+               dbName, [err localizedDescription]);
+        err = nil;
+
+        // Delete the database and try again.
+        [self purgeDatabase:dbName];
+        db = [APLevelDB levelDBWithPath:path error:&err];
+
+        if (err) {
+            NSString *reason = [NSString stringWithFormat:@"Error initializing persistence: %@", [err description]];
+            @throw [NSException exceptionWithName:@"FirebaseDatabasePersistenceFailure" reason:reason userInfo:nil];
+        }
     }
+
     return db;
 }
 
-- 
cgit v1.2.3