From 1476e2bfe5db393ac3b069c1e12d14f91f6b529b Mon Sep 17 00:00:00 2001 From: Chen Liang Date: Thu, 26 Apr 2018 11:22:25 -0700 Subject: shouldEstablishDirectChannel cannot be replaced by isDirectChannelEstablished as it represents whether user "should" connect instead of whether user "is" connected (#1190) shouldEstablishDirectChannel cannot be replaced by isDirectChannelEstablished as it represents whether user "should" connect instead of whether user "is" connected --- Firebase/Messaging/FIRMessaging.m | 4 +--- Firebase/Messaging/Public/FIRMessaging.h | 7 ++++++- 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'Firebase/Messaging') diff --git a/Firebase/Messaging/FIRMessaging.m b/Firebase/Messaging/FIRMessaging.m index 8fafab8..339bd7d 100644 --- a/Firebase/Messaging/FIRMessaging.m +++ b/Firebase/Messaging/FIRMessaging.m @@ -124,9 +124,7 @@ static NSString *const kFIRMessagingPlistAutoInitEnabled = @end @interface FIRMessaging () { - BOOL _shouldEstablishDirectChannel; -} + FIRReachabilityDelegate> // FIRApp properties @property(nonatomic, readwrite, copy) NSString *fcmSenderID; diff --git a/Firebase/Messaging/Public/FIRMessaging.h b/Firebase/Messaging/Public/FIRMessaging.h index 3ad15da..e58a216 100644 --- a/Firebase/Messaging/Public/FIRMessaging.h +++ b/Firebase/Messaging/Public/FIRMessaging.h @@ -291,7 +291,12 @@ NS_SWIFT_NAME(Messaging) * receiving non-APNS, data-only messages in foregrounded apps. * Default is `NO`. */ -@property(nonatomic, assign, getter=isDirectChannelEstablished) BOOL shouldEstablishDirectChannel; +@property(nonatomic) BOOL shouldEstablishDirectChannel; + +/** + * Returns `YES` if the direct channel to the FCM server is active, and `NO` otherwise. + */ +@property(nonatomic, readonly) BOOL isDirectChannelEstablished; /** * FIRMessaging -- cgit v1.2.3