From 5de20858e405d714cc2b9d623bdd7705933d8255 Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Wed, 13 Jun 2018 07:56:28 -0700 Subject: Remove unused static logging variable. (#1405) * Remove unused static variable. This was previously used in an iOS 7 comparison that was removed in Firebase version 5.0.0. * Remove unused test variable. --- Example/Core/Tests/FIRLoggerTest.m | 10 ---------- Firebase/Core/FIRLogger.m | 4 ---- 2 files changed, 14 deletions(-) diff --git a/Example/Core/Tests/FIRLoggerTest.m b/Example/Core/Tests/FIRLoggerTest.m index 0d6d4e2..c1ba37b 100644 --- a/Example/Core/Tests/FIRLoggerTest.m +++ b/Example/Core/Tests/FIRLoggerTest.m @@ -29,8 +29,6 @@ extern NSString *const kFIRPersistedDebugModeKey; extern const char *kFIRLoggerASLClientFacilityName; -extern const char *kFIRLoggerCustomASLMessageFormat; - extern void FIRResetLogger(void); extern aslclient getFIRLoggerClient(void); @@ -39,10 +37,6 @@ extern dispatch_queue_t getFIRClientQueue(void); extern BOOL getFIRLoggerDebugMode(void); -// Define the message format again to make sure the format doesn't accidentally change. -static NSString *const kCorrectASLMessageFormat = - @"$((Time)(J.3)) $(Sender)[$(PID)] <$((Level)(str))> $Message"; - static NSString *const kMessageCode = @"I-COR000001"; @interface FIRLoggerTest : FIRTestCase @@ -71,10 +65,6 @@ static NSString *const kMessageCode = @"I-COR000001"; // Test some stable variables to make sure they weren't accidently changed. - (void)testStableVariables { - // kFIRLoggerCustomASLMessageFormat. - XCTAssertEqualObjects(kCorrectASLMessageFormat, - [NSString stringWithUTF8String:kFIRLoggerCustomASLMessageFormat]); - // Strings of type FIRLoggerServices. XCTAssertEqualObjects(kFIRLoggerABTesting, @"[Firebase/ABTesting]"); XCTAssertEqualObjects(kFIRLoggerAdMob, @"[Firebase/AdMob]"); diff --git a/Firebase/Core/FIRLogger.m b/Firebase/Core/FIRLogger.m index 03f8a79..ae14e9f 100644 --- a/Firebase/Core/FIRLogger.m +++ b/Firebase/Core/FIRLogger.m @@ -54,10 +54,6 @@ NSString *const kFIRPersistedDebugModeKey = @"/google/firebase/debug_mode"; /// ASL client facility name used by FIRLogger. const char *kFIRLoggerASLClientFacilityName = "com.firebase.app.logger"; -/// Message format used by ASL client that matches format of NSLog. -const char *kFIRLoggerCustomASLMessageFormat = - "$((Time)(J.3)) $(Sender)[$(PID)] <$((Level)(str))> $Message"; - /// Keys for the number of errors and warnings logged. NSString *const kFIRLoggerErrorCountKey = @"/google/firebase/count_of_errors_logged"; NSString *const kFIRLoggerWarningCountKey = @"/google/firebase/count_of_warnings_logged"; -- cgit v1.2.3