aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/Source
Commit message (Collapse)AuthorAge
* Fix issue @morganchen12 discovered where we weren't properly creating ↵Gravatar Michael Lehenbauer2018-01-12
| | | | | | FIRQueryDocumentSnapshot instances. (#662)
* Remove over-aggressive closeWithFinalState: delegate assert. (#656)Gravatar Michael Lehenbauer2018-01-11
| | | | | | | | | Fixes #596. closeWithFinalState: asserted delegate != nil, but that is not true if when startWithdelegate: was called we entered backoff (performBackoffWithDelegate:) and so self.delegate did not get assigned yet. We could rework the code to make the assertion hold, but per offline discussion this assert doesn't represent an invariant that we care about maintaining and so I'm just removing it.
* Fix FSTLocalDocumentsView to allow multiple mutations while offline (#644)Gravatar rsgowman2018-01-11
| | | | | * Fix FSTLocalDocumentsView to allow multiple mutations while offline. Previously, only the last mutation would actually be visible.
* Run style.sh (#636)Gravatar Michael Lehenbauer2018-01-10
| | | | Run style.sh (w/ clang-format version 6)
* Fixing potential race in ServerTimestamp testsGravatar Sebastian Schmidt2018-01-05
|
* Log pending writes when we disable the network (#604)Gravatar Greg Soltis2018-01-02
| | | | | | | | * Log pending writes when we disable the network * Fix formatting * Formatting
* Fix races in lazy initialization of the client in FIRFirestore (#579)Gravatar Gil2017-12-20
| | | | | | | | * Fix races in lazy initialization of the client in FIRFirestore Note that lazy initialization is required because we allow the user to assign to settings after instantiation before any methods are used. Also bring method naming closer to the android port.
* Rename all the onlineStateChanged methods to applyChangedOnlineState. (#574)Gravatar Michael Lehenbauer2017-12-19
|
* Firestore `isEqual()` on Public Types (#569)Gravatar zxu2017-12-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add bone code for new isEqual and unit test for old isEqual * add bone code for `FIRCollectionReference`, `FIRDocumentSnapshot`, `FIRFieldValue`, `FIRQuerySnapshot`, `FIRSnapshotMetadata`; * change inconsistenciness of `FIRFieldPath.isEqual` implementation; * add unit test (and file) for `FIRDocumentReferenceTest.m`, `FIRFieldPathTest.m`, `FIRQueryTests.testEquals`; `FIRGeoPoint` already has test and Blob is internal type. * Implement isEqual for FIRCollectionReference adding the working code and unit test. * implement isEqual for FIRSnapshotMetadata * Implement isEqual for FIRDocumentSnapshot * Implement isEqual for FIRQuerySnapshot * (un)implement `isEqual` for `FIRFieldValue` Since `FIRFieldValue` both types are singleton, we do not need override `isEqual`. Add test to test the default `NSObject` `isEqual` works just fine. * fix style with `scripts/style.sh` * Implement hash for those with overridden isEqual without hash yet. * refactor to use test helper functions -- FSTTestFirestore, FSTTestPath, FSTTestDocKey * refactor using test helper `FSTTestDocSnapshot`, `FSTTestFieldPath`, `FSTTestQuery`, `FSTTestDoc` * refactoring to use test helper method `FSTTestQuerySnapshot`, * remove unneccessary nil-check, check isKindOfClass instead of isEqual * refactoring: adding `FSTAPIHelpers.{h,m}`, `FSTTest{Collection,Document}Ref`, better naming and style fix * a file forgot in last commit * mainly clean up import and some minor refactoring * fix style via style.sh * minor style fix * add pragma ignored -Wnonnull
* Expose network management (#566)Gravatar Greg Soltis2017-12-18
| | | | | | | | | | | | | | | | | | * Expose network management in public API * Clean up a few more references to the internal access of network management * Move test * Update comments * Swap _Nullable for nullable * Fix comment * Add tests, including swift * Styling
* Test cleanup: Adds a helper for waiting for FSTVoidErrorBlock callbacks.Gravatar Michael Lehenbauer2017-12-18
| | | | | | | * Add helper for waiting for FSTVoidErrorBlock callbacks. * Remove errorEventHandler from FSTEventAccumulator.h too. * Add synchronous enableNetwork / disableNetwork helpers. * Workaround for batch writes test flakiness.
* b/68276665: Raise isFromCache=true events when offline (#567)Gravatar Michael Lehenbauer2017-12-15
| | | | | | | | | | | | | | | | * Plumbs FSTOnlineState changes through to views. * View sets this.current to false on FSTOnlineStateFailed, triggering isFromCache=true events. It will automatically be returned to true once the listen is reestablished and we get a new CURRENT message. * Updated tests (and added one new one) to verify behavior. * Unifies setOnlineStateToUnknown, setOnlineStateToHealthy, and updateAndBroadcastOnlineState into a single updateOnlineState method. * Split disableNetwork into (public) disableNetwork and (private) disableNetworkWithTargetOnlineState methods.. * Some miscellaneous comment cleanup. * Add missing comment per CR feedback.
* Merge pull request #565 from firebase/mrschmidt-missingmethodsGravatar Sebastian Schmidt2017-12-15
|\ | | | | Adding missing SnapshotOptions method
| * Adding Swift build testGravatar Sebastian Schmidt2017-12-14
| |
| * Adding missing SnapshotOptions methodGravatar Sebastian Schmidt2017-12-13
| |
* | Fix new warnings w.r.t. predicate query change (#555)Gravatar zxu2017-12-12
|/
* Adding missing word in commentGravatar Sebastian Schmidt2017-12-12
|
* Using 100 as line length for commentsGravatar Sebastian Schmidt2017-12-12
|
* MergeGravatar Sebastian Schmidt2017-12-12
|\
| * Merge branch 'firestore-api-changes' into mrschmidt-timestampsGravatar Sebastian Schmidt2017-12-12
| |\
* | | Addressing commentsGravatar Sebastian Schmidt2017-12-12
| | |
| * | Addressing commentsGravatar Sebastian Schmidt2017-12-12
| | |
| * | Adding GenericsGravatar Sebastian Schmidt2017-12-12
| | |
| | * Revisit commit method in FIRWriteBatch (#541)Gravatar zxu2017-12-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * revisit FIRWriteBatch commit * make commitWithCompletion completion nullable; * add commit; * add unit test; * add swift build test for commit; * update CHANGELOG.
* | | Comment fixGravatar Sebastian Schmidt2017-12-10
| | |
* | | Clang formatGravatar Sebastian Schmidt2017-12-10
| | |
| | * Running scripts/style.shGravatar Sebastian Schmidt2017-12-10
| | |
* | | Making DocumentSnapshot nullableGravatar Sebastian Schmidt2017-12-10
| |/ |/|
| * Adding default optionGravatar Sebastian Schmidt2017-12-08
| |
* | make FIRDocumentListenOptions.includeMetadataChanges private (#540)Gravatar zxu2017-12-08
| | | | | | | | | | | | | | | | * make FIRDocumentListenOptions.includeMetadataChanges private as discussed in Firestore API discussion, the name clashes creates confusion. Android SDK already not exposing the property; here change iOS SDK to match it. * update CHANGELOG
| * Method renamesGravatar Sebastian Schmidt2017-12-07
| |
| * Addressing all review commentsGravatar Sebastian Schmidt2017-12-07
| |
* | Merge pull request #542 from firebase/masterGravatar Gil2017-12-07
|\ \ | | | | | | sync firestore-api-changes with master
* | | Implement NSPredicate-based query (#531)Gravatar zxu2017-12-07
| | | | | | | | | | | | | | | | | | * implement queryFilteredUsingPredicate in FIRQuery; * add unit test and integration test for queryFilteredUsingPredicate; * project change of adding the FIRQueryTests.m file; * refactoring queryFilteredUsingPredicate to split logic into two helpers;
| * | Add FirebaseFirestore.h to fix Firebase module in source build (#539)Gravatar Paul Beusterien2017-12-07
| | |
| * | Merge pull request #514 from firebase/zxu/logofflineGravatar zxu2017-12-07
|/| | | | | | | | Warn user if we raise with empty while not online
| * | refactoring the condition when to warn offlineGravatar zxu1232017-12-06
| | |
| | * Adding SnapshotOptions to deal with pending ServerTimestampsGravatar Sebastian Schmidt2017-12-05
| |/ |/|
| * implement log warning for offline statusGravatar zxu1232017-12-05
| | | | | | | | | | * Move the logic from FSTEventManager to FSTRemoteStore. Pros: per query vs per stream. * Since state can go into unknown normally (e.g. no listener is registered and nobody care the status), we only warns when status is actually offline to avoid confusion.
* | Standardize cross module imports with angle bracket syntax (#526)Gravatar Paul Beusterien2017-12-04
| | | | | | | | Qualify all cross-pod imports of FirebaseCore headers
| * Merge branch 'master' into zxu/logofflineGravatar zxu1232017-12-04
| |\ | |/ |/| | | | | fix pod error: [!] CocoaPods could not find compatible versions for pod "FirebaseCor
* | Cleanup import path for FIRLogger (#523)Gravatar rsgowman2017-12-01
| |
* | Merge pull request #522 from firebase/mrschmidt-crashGravatar Sebastian Schmidt2017-12-01
|\ \ | | | | | | Ignoring stream messages for closed streams
| * | Ignoring stream messages for closed streamsGravatar Sebastian Schmidt2017-12-01
| | |
* | | Merge pull request #510 from firebase/mrschmidt-crashGravatar Sebastian Schmidt2017-12-01
|\| | | | | | | | Fixing race in FSTWriteStream
* | | Fix long line and run style (#517)Gravatar Paul Beusterien2017-11-30
| | |
| * | Checking for stream close in handleStreamCloseGravatar Sebastian Schmidt2017-11-30
| | |
* | | add completion execution guarantees to firestore write ops (#481)Gravatar Morgan Chen2017-11-30
| | |
| | * Warn user if we raise with empty while not onlineGravatar zxu1232017-11-30
| | | | | | | | | | | | To avoid surprise by adding a warning. Right now, when offline, empty result is returned with no log nor error, see https://groups.google.com/forum/#!topic/google-cloud-firestore-discuss/puFl9HVU57I/discussion
* | | Move sources into firebase::firestore and internal namespaces (#494)Gravatar Gil2017-11-30
| |/ |/| | | | | | | | | | | * Move sources into firebase::firestore and internal namespaces Combine support and core/util packages; this distinction wasn't really paying its freight.