aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/core/test
diff options
context:
space:
mode:
authorGravatar rsgowman <rgowman@google.com>2018-05-02 16:27:04 -0400
committerGravatar GitHub <noreply@github.com>2018-05-02 16:27:04 -0400
commitfdbb2f121c903d456bd89e868742c239a867c7a8 (patch)
treed7b84e443319efdb46c5bab1af91221666e0467b /Firestore/core/test
parent542d81ac68c416e8d76839e438ad1d6aaab528f3 (diff)
Minor test naming fixup (#1209)
Diffstat (limited to 'Firestore/core/test')
-rw-r--r--Firestore/core/test/firebase/firestore/remote/serializer_test.cc15
1 files changed, 6 insertions, 9 deletions
diff --git a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
index a2036a8..ecfbf32 100644
--- a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
+++ b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
@@ -204,22 +204,19 @@ class SerializerTest : public ::testing::Test {
}
};
-// TODO(rsgowman): whoops! A previous commit performed approx s/Encodes/Writes/,
-// but should not have done so here. Change it back in this file.
-
-TEST_F(SerializerTest, WritesNull) {
+TEST_F(SerializerTest, EncodesNull) {
FieldValue model = FieldValue::NullValue();
ExpectRoundTrip(model, ValueProto(nullptr), FieldValue::Type::Null);
}
-TEST_F(SerializerTest, WritesBool) {
+TEST_F(SerializerTest, EncodesBool) {
for (bool bool_value : {true, false}) {
FieldValue model = FieldValue::BooleanValue(bool_value);
ExpectRoundTrip(model, ValueProto(bool_value), FieldValue::Type::Boolean);
}
}
-TEST_F(SerializerTest, WritesIntegers) {
+TEST_F(SerializerTest, EncodesIntegers) {
std::vector<int64_t> cases{0,
1,
-1,
@@ -234,7 +231,7 @@ TEST_F(SerializerTest, WritesIntegers) {
}
}
-TEST_F(SerializerTest, WritesString) {
+TEST_F(SerializerTest, EncodesString) {
std::vector<std::string> cases{
"",
"a",
@@ -257,7 +254,7 @@ TEST_F(SerializerTest, WritesString) {
}
}
-TEST_F(SerializerTest, WritesEmptyMap) {
+TEST_F(SerializerTest, EncodesEmptyMap) {
FieldValue model = FieldValue::ObjectValueFromMap({});
google::firestore::v1beta1::Value proto;
@@ -266,7 +263,7 @@ TEST_F(SerializerTest, WritesEmptyMap) {
ExpectRoundTrip(model, proto, FieldValue::Type::Object);
}
-TEST_F(SerializerTest, WritesNestedObjects) {
+TEST_F(SerializerTest, EncodesNestedObjects) {
FieldValue model = FieldValue::ObjectValueFromMap({
{"b", FieldValue::TrueValue()},
// TODO(rsgowman): add doubles (once they're supported)