diff options
| author |  Gil <mcg@google.com> | 2018-04-12 14:54:53 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-12 14:54:53 -0700 |
| commit | 8876622b6fcebc21672bc263666b858b7e152b45 (patch) | |
| tree | 053fe00a20207099c11c1464df25565a5f5cc3c6 /Firestore/core/src/firebase/firestore/core | |
| parent | 1397e4ae72ea3b8d16a9b44ed1235caca47b3d9e (diff) | |
Add clang-tidy checks for Firestore (#1078)
* Add a .clang-tidy configuration for Firestore C++
* Fix clang-tidy warnings
* typedef -> using
* const ref + rvalue ref -> pass by value
* NULL -> nullptr
* remove useless default initializations
* remove useless const value-type parameter declarations (definitions
can still use them)
* use auto instead of repeating types in a cast
* Fix typos
* Address use of static method through instance warnings
* Address use after move warnings
Diffstat (limited to 'Firestore/core/src/firebase/firestore/core')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/core/database_info.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Firestore/core/src/firebase/firestore/core/database_info.h b/Firestore/core/src/firebase/firestore/core/database_info.h index 2e1303e..0f97b1f 100644 --- a/Firestore/core/src/firebase/firestore/core/database_info.h +++ b/Firestore/core/src/firebase/firestore/core/database_info.h @@ -41,12 +41,12 @@ class DatabaseInfo { * @param database_id The project/database to use. * @param persistence_key A unique identifier for this Firestore's local * storage. Usually derived from -[FIRApp appName]. - * @param host The hostname of the datastore backend. + * @param host The hostname of the Firestore backend. * @param ssl_enabled Whether to use SSL when connecting. */ DatabaseInfo(const firebase::firestore::model::DatabaseId& database_id, - const absl::string_view persistence_key, - const absl::string_view host, + absl::string_view persistence_key, + absl::string_view host, bool ssl_enabled); const firebase::firestore::model::DatabaseId& database_id() const { |