Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | Review comments. | David Benjamin | 2018-03-09 |
| | | | | | | | Major change is porting everything to Z and using Z.div_mod_to_quot_rem which is a handy sledgehammer. Z is also a nice simplification. Dealing with subtraction is tidier, though I do have 0 <= x goals everywhere as a result. | ||
* | easy bits | David Benjamin | 2018-03-09 |
| | |||
* | Prove another Barrett reduction variant. | David Benjamin | 2018-03-09 |
| | | | | | | | | | | This variant comes from http://www.ridiculousfish.com/blog/posts/labor-of-division-episode-i.html. It was useful for https://boringssl-review.googlesource.com/#/c/boringssl/+/25887. TODO - Talk to Andres to figure out all the ways this could be done more cleanly. It was originally a standalone file. | ||
* | Don't use deprecated compat notations in ZUtil | Jason Gross | 2018-03-07 |
| | |||
* | Add comments about [refresh] failing | Jason Gross | 2018-03-07 |
| | |||
* | actually reprint montgomery and uncomment a couple notations -- should have ↵ | Jade Philipoom | 2018-03-07 |
| | | | | been in last commit | ||
* | fix a typo, some comments, and notations | Jade Philipoom | 2018-03-07 |
| | |||
* | make Montgomery do associational carries in a generalized way | Jade Philipoom | 2018-03-07 |
| | |||
* | remove special-case convert-mul-convert implementation and use generalized ↵ | Jade Philipoom | 2018-03-07 |
| | | | | one in Montgomery example | ||
* | remove unneeded, commented-out code | Jade Philipoom | 2018-03-07 |
| | |||
* | Add a dummy length argument to make partial evaluation work (see #321) and ↵ | Jade Philipoom | 2018-03-07 |
| | | | | fixed up Montgomery notations | ||
* | factor out convert-mul-convert and prove correctness | Jade Philipoom | 2018-03-07 |
| | |||
* | git submodule update --remote --recursive | Andres Erbsen | 2018-02-24 |
| | |||
* | coqprime in COQPATH (closes #269) | Andres Erbsen | 2018-02-24 |
| | |||
* | Add ZRange.intersection | Jason Gross | 2018-02-23 |
| | |||
* | Fix a typo | Jason Gross | 2018-02-23 |
| | |||
* | Add some bounds operations to ZRange | Jason Gross | 2018-02-23 |
| | |||
* | Add ZRange.opp | Jason Gross | 2018-02-23 |
| | |||
* | Make the Montgomery reduction test case use 128-bit multiplications and | Jade Philipoom | 2018-02-23 |
| | | | | | | | | Columns arithmetic. This includes: - writing flatten_column in terms of list_rect instead of matches, so it can be reified - adding list_rect, shiftl, and List.length to various IRs - dead code elimination | ||
* | fix leftover %RT | Jade Philipoom | 2018-02-23 |
| | |||
* | Get bounds analysis working | Jade Philipoom | 2018-02-23 |
| | |||
* | fixed inlining of opaque pairs as per Jason's recommendation | Jade Philipoom | 2018-02-23 |
| | |||
* | rename compact_digit to flatten_column | Jade Philipoom | 2018-02-23 |
| | |||
* | make compact_digit consume a bound argument rather than a weight-function index | Jade Philipoom | 2018-02-23 |
| | |||
* | use Z.div and Z.modulo in saturated arith, since we can now change to ↵ | Jade Philipoom | 2018-02-23 |
| | | | | bitshifts reflectively | ||
* | remove leftover [Eval compute] and extra space | Jade Philipoom | 2018-02-23 |
| | |||
* | Fix naming issue | Jade Philipoom | 2018-02-23 |
| | |||
* | move things from ZUtil.v into Div.v | Jade Philipoom | 2018-02-23 |
| | |||
* | define mul and add placeholders for new operations in bounds parts | Jade Philipoom | 2018-02-23 |
| | |||
* | Add non-CPS version of Saturated/Core | Jade Philipoom | 2018-02-23 |
| | |||
* | add three proofs to ZUtil | Jade Philipoom | 2018-02-23 |
| | |||
* | add two proofs about lists | Jade Philipoom | 2018-02-23 |
| | |||
* | Add non-CPS version of associational multiplication with mul_split | Jade Philipoom | 2018-02-23 |
| | |||
* | preliminary version of Montgomery reduce in new pipeline; includes adding ↵ | Jade Philipoom | 2018-02-23 |
| | | | | support for Z.leb and several saturated-arith operations (add_get_carry, add_with_get_carry, sub_get_borrow, mul_split, zselect, and add_modulo) | ||
* | add proof about Z.equiv_modulo | Jade Philipoom | 2018-02-23 |
| | |||
* | add equivalence proof for Montgomery reduce_via_partial_alt | Jade Philipoom | 2018-02-23 |
| | |||
* | create rewrite database for saturated operations on Z | Jade Philipoom | 2018-02-23 |
| | |||
* | Add new modular addition operation on Z | Jade Philipoom | 2018-02-23 |
| | |||
* | Fix balance on sub | Jason Gross | 2018-02-19 |
| | | | | | | | With some help from @jadephilipoom Previously, the carrying was removing the effect of `coef`, and we were getting too small a balance. | ||
* | A bit more uniformity in handling the prime, implicits | Jason Gross | 2018-02-19 |
| | |||
* | [experiments] Fill in opp and sub | Jason Gross | 2018-02-19 |
| | |||
* | Remove the mod on eval_add | Jason Gross | 2018-02-19 |
| | |||
* | Remove runtime_scope | Jason Gross | 2018-02-19 |
| | | | | As per https://github.com/mit-plv/fiat-crypto/pull/315#discussion_r169085799 | ||
* | [experiments] Add some more arithmetic operations | Jason Gross | 2018-02-19 |
| | |||
* | NumTheoryUtil: make coqprime dependencies explicit | Andres Erbsen | 2018-02-19 |
| | |||
* | Take in n, compute limbwidth | Jason Gross | 2018-02-18 |
| | |||
* | Rename type_descr to second_order, as per PR request | Jason Gross | 2018-02-18 |
| | |||
* | Rename AutoReify | Jason Gross | 2018-02-18 |
| | |||
* | Speed up the pipeline by 3x, restoring previous performance | Jason Gross | 2018-02-18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apparently using `refine eq_refl` rather than `subst <name for evar>; reflexivity` was resulting in βδ reduction of `chained_carries` in `carry_mulmod`. The β reduction resulted in us getting a different cps'd term. I do not know why this particular β reduction resulted in a 3x slowdown in partial reduction; it seems like anything that cared about sharing should either get sharing from the top-level in `carry_mulmod`, or should have no difference in sharing between the terms ```coq (fun n s c p idxs => fold_right (fun a b => @carry_reduce n s c a b) p (rev idxs)) n s c p idxs ``` and ```coq fold_right (fun a b => @carry_reduce n s c a b) p (rev idxs)) ``` This feels fragile, and I am mystified. Note for the future: I went about debugging this by integrating little bits of this PR one by one, seeing which one caused the slowdown, and then, when I realized it was use of `carry_mulmod`, I took the reified terms and made a goal asserting their equality, and then took the terms apart with `f_equal` and `extensionality` until I found the difference. | ||
* | Remove mul_rargs record | Jason Gross | 2018-02-18 |
| |