From 1bbcf19029ea3ac5493c3511807daa53fcde9e90 Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Fri, 9 Jun 2017 14:44:02 +0200 Subject: bug #1403: fix implicit scalar type conversion. --- Eigen/src/QR/ColPivHouseholderQR.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Eigen/src/QR') diff --git a/Eigen/src/QR/ColPivHouseholderQR.h b/Eigen/src/QR/ColPivHouseholderQR.h index 1b828f5dc..ae7c1775f 100644 --- a/Eigen/src/QR/ColPivHouseholderQR.h +++ b/Eigen/src/QR/ColPivHouseholderQR.h @@ -555,7 +555,7 @@ void ColPivHouseholderQR::computeInPlace() if (m_colNormsUpdated.coeffRef(j) != 0) { RealScalar temp = abs(m_qr.coeffRef(k, j)) / m_colNormsUpdated.coeffRef(j); temp = (RealScalar(1) + temp) * (RealScalar(1) - temp); - temp = temp < 0 ? 0 : temp; + temp = temp < 0 ? RealScalar(0) : temp; RealScalar temp2 = temp * numext::abs2(m_colNormsUpdated.coeffRef(j) / m_colNormsDirect.coeffRef(j)); if (temp2 <= norm_downdate_threshold) { -- cgit v1.2.3