From 302a404b7e764ae890e30b37f1b32bc5e4b871ea Mon Sep 17 00:00:00 2001 From: Rasmus Munk Larsen Date: Thu, 20 Jun 2019 15:59:08 -0700 Subject: Added comment explaining the surprising EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC clause. --- Eigen/src/Core/arch/GPU/Half.h | 3 +++ Eigen/src/Core/arch/GPU/PacketMath.h | 3 +++ 2 files changed, 6 insertions(+) (limited to 'Eigen/src/Core') diff --git a/Eigen/src/Core/arch/GPU/Half.h b/Eigen/src/Core/arch/GPU/Half.h index 732975729..bd0c2a0b3 100644 --- a/Eigen/src/Core/arch/GPU/Half.h +++ b/Eigen/src/Core/arch/GPU/Half.h @@ -313,6 +313,9 @@ EIGEN_STRONG_INLINE __device__ bool operator >= (const half& a, const half& b) { #endif +// The EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC clause is necessary on Mac where we +// that suspect NVCC doing device-side preprocessing with clang, but actually +// compiling with cicc, which is obviously not clang. #if !defined(EIGEN_HAS_NATIVE_FP16) || (EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC) // Emulate support for half floats #if EIGEN_COMP_CLANG && defined(EIGEN_CUDACC) diff --git a/Eigen/src/Core/arch/GPU/PacketMath.h b/Eigen/src/Core/arch/GPU/PacketMath.h index e50d16246..54e4e9f22 100644 --- a/Eigen/src/Core/arch/GPU/PacketMath.h +++ b/Eigen/src/Core/arch/GPU/PacketMath.h @@ -102,6 +102,9 @@ template<> EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE double2 pset1(const do return make_double2(from, from); } +// The EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC clause is necessary on Mac where we +// that suspect NVCC doing device-side preprocessing with clang, but actually +// compiling with cicc, which is obviously not clang. #if defined(EIGEN_CUDA_ARCH) || defined(EIGEN_HIP_DEVICE_COMPILE) || (defined(EIGEN_CUDACC) && EIGEN_COMP_CLANG && !EIGEN_COMP_NVCC) namespace { -- cgit v1.2.3