From a7d2552af8b34f6befba9988c36fe5d9723892e6 Mon Sep 17 00:00:00 2001
From: Antonio Sanchez <cantonios@google.com>
Date: Thu, 28 May 2020 10:41:28 -0700
Subject: Remove HasCast and fix packetmath cast tests.

The use of the `packet_traits<>::HasCast` field is currently inconsistent with
`type_casting_traits<>`, and is unused apart from within
`test/packetmath.cpp`. In addition, those packetmath cast tests do not
currently reflect how casts are performed in practice: they ignore the
`SrcCoeffRatio` and `TgtCoeffRatio` fields, assuming a 1:1 ratio.

Here we remove the unsed `HasCast`, and modify the packet cast tests to
better reflect their usage.
---
 Eigen/src/Core/arch/NEON/PacketMath.h | 10 ----------
 1 file changed, 10 deletions(-)

(limited to 'Eigen/src/Core/arch/NEON/PacketMath.h')

diff --git a/Eigen/src/Core/arch/NEON/PacketMath.h b/Eigen/src/Core/arch/NEON/PacketMath.h
index 065c8100f..ddd43c377 100644
--- a/Eigen/src/Core/arch/NEON/PacketMath.h
+++ b/Eigen/src/Core/arch/NEON/PacketMath.h
@@ -121,7 +121,6 @@ struct packet_traits<float> : default_packet_traits
     size = 4,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -162,7 +161,6 @@ struct packet_traits<int8_t> : default_packet_traits
     size = 16,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -192,7 +190,6 @@ struct packet_traits<uint8_t> : default_packet_traits
     size = 16,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -224,7 +221,6 @@ struct packet_traits<int16_t> : default_packet_traits
     size = 8,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -254,7 +250,6 @@ struct packet_traits<uint16_t> : default_packet_traits
     size = 8,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -285,7 +280,6 @@ struct packet_traits<int32_t> : default_packet_traits
     size = 4,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -315,7 +309,6 @@ struct packet_traits<uint32_t> : default_packet_traits
     size = 4,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasAdd       = 1,
     HasSub       = 1,
     HasShift     = 1,
@@ -347,7 +340,6 @@ struct packet_traits<int64_t> : default_packet_traits
     size = 2,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasCmp       = 1,
     HasAdd       = 1,
     HasSub       = 1,
@@ -378,7 +370,6 @@ struct packet_traits<uint64_t> : default_packet_traits
     size = 2,
     HasHalfPacket = 1,
 
-    HasCast      = 1,
     HasCmp       = 1,
     HasAdd       = 1,
     HasSub       = 1,
@@ -3185,7 +3176,6 @@ template<> struct packet_traits<double>  : default_packet_traits
     size = 2,
     HasHalfPacket = 0,
 
-    HasCast      = 1,
     HasCmp       = 1,
     HasAdd       = 1,
     HasSub       = 1,
-- 
cgit v1.2.3