From deecff97edfb6f75e7613e1db97a1e3e5504e971 Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Tue, 10 Feb 2015 19:22:05 +0100 Subject: typo --- blas/common.h | 3 +-- blas/level3_impl.h | 2 +- blas/xerbla.cpp | 4 ++-- unsupported/Eigen/src/IterativeSolvers/MINRES.h | 4 ++-- unsupported/test/minres.cpp | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/blas/common.h b/blas/common.h index c39cc63a8..5ecb153e2 100644 --- a/blas/common.h +++ b/blas/common.h @@ -1,7 +1,7 @@ // This file is part of Eigen, a lightweight C++ template library // for linear algebra. // -// Copyright (C) 2009-2010 Gael Guennebaud +// Copyright (C) 2009-2015 Gael Guennebaud // // This Source Code Form is subject to the terms of the Mozilla // Public License v. 2.0. If a copy of the MPL was not distributed @@ -13,7 +13,6 @@ #include #include -#include #include #ifndef SCALAR diff --git a/blas/level3_impl.h b/blas/level3_impl.h index a05872666..32313e814 100644 --- a/blas/level3_impl.h +++ b/blas/level3_impl.h @@ -8,7 +8,7 @@ // with this file, You can obtain one at http://mozilla.org/MPL/2.0/. #include "common.h" - +#include int EIGEN_BLAS_FUNC(gemm)(char *opa, char *opb, int *m, int *n, int *k, RealScalar *palpha, RealScalar *pa, int *lda, RealScalar *pb, int *ldb, RealScalar *pbeta, RealScalar *pc, int *ldc) { // std::cerr << "in gemm " << *opa << " " << *opb << " " << *m << " " << *n << " " << *k << " " << *lda << " " << *ldb << " " << *ldc << " " << *palpha << " " << *pbeta << "\n"; diff --git a/blas/xerbla.cpp b/blas/xerbla.cpp index 0422f79b7..8775b88cd 100644 --- a/blas/xerbla.cpp +++ b/blas/xerbla.cpp @@ -1,5 +1,5 @@ -#include +#include #if (defined __GNUC__) && (!defined __MINGW32__) #define EIGEN_WEAK_LINKING __attribute__ ((weak)) @@ -14,7 +14,7 @@ extern "C" EIGEN_WEAK_LINKING int xerbla_(const char * msg, int *info, int) { - std::cerr << "Eigen BLAS ERROR #" << *info << ": " << msg << "\n"; + printf("Eigen BLAS ERROR #%i: %s\n", *info, msg ); return 0; } diff --git a/unsupported/Eigen/src/IterativeSolvers/MINRES.h b/unsupported/Eigen/src/IterativeSolvers/MINRES.h index 65cffc255..93a83e5b7 100644 --- a/unsupported/Eigen/src/IterativeSolvers/MINRES.h +++ b/unsupported/Eigen/src/IterativeSolvers/MINRES.h @@ -165,8 +165,8 @@ namespace Eigen { * The vectors x and b can be either dense or sparse. * * \tparam _MatrixType the type of the sparse matrix A, can be a dense or a sparse matrix. - * \tparam _UpLo the triangular part that will be used for the computations. It can be Lower - * or Upper. Default is Lower. + * \tparam _UpLo the triangular part that will be used for the computations. It can be Lower, + * Upper, or Lower|Upper in which the full matrix entries will be considered. Default is Lower. * \tparam _Preconditioner the type of the preconditioner. Default is DiagonalPreconditioner * * The maximal number of iterations and tolerance value can be controlled via the setMaxIterations() diff --git a/unsupported/test/minres.cpp b/unsupported/test/minres.cpp index f6e526bbd..8b300b78a 100644 --- a/unsupported/test/minres.cpp +++ b/unsupported/test/minres.cpp @@ -21,7 +21,7 @@ template void test_minres_T() // Diagonal preconditioner MINRES, Lower, DiagonalPreconditioner > minres_colmajor_lower_diag; MINRES, Upper, DiagonalPreconditioner > minres_colmajor_upper_diag; - MINRES, Upper, DiagonalPreconditioner > minres_colmajor_uplo_diag; + MINRES, Lower|Upper, DiagonalPreconditioner > minres_colmajor_uplo_diag; // call tests for SPD matrix CALL_SUBTEST( check_sparse_spd_solving(minres_colmajor_lower_I) ); -- cgit v1.2.3