aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
-rw-r--r--Eigen/src/SVD/UpperBidiagonalization.h5
-rw-r--r--doc/TopicLinearAlgebraDecompositions.dox12
-rw-r--r--test/upperbidiagonalization.cpp2
3 files changed, 6 insertions, 13 deletions
diff --git a/Eigen/src/SVD/UpperBidiagonalization.h b/Eigen/src/SVD/UpperBidiagonalization.h
index c9ba325ed..1009f5fe1 100644
--- a/Eigen/src/SVD/UpperBidiagonalization.h
+++ b/Eigen/src/SVD/UpperBidiagonalization.h
@@ -25,6 +25,10 @@
#ifndef EIGEN_BIDIAGONALIZATION_H
#define EIGEN_BIDIAGONALIZATION_H
+namespace internal {
+// UpperBidiagonalization will probably be replaced by a Bidiagonalization class, don't want to make it stable API.
+// At the same time, it's useful to keep for now as it's about the only thing that is testing the BandMatrix class.
+
template<typename _MatrixType> class UpperBidiagonalization
{
public:
@@ -149,5 +153,6 @@ MatrixBase<Derived>::bidiagonalization() const
}
#endif
+} // end namespace internal
#endif // EIGEN_BIDIAGONALIZATION_H
diff --git a/doc/TopicLinearAlgebraDecompositions.dox b/doc/TopicLinearAlgebraDecompositions.dox
index 574962033..5684a495f 100644
--- a/doc/TopicLinearAlgebraDecompositions.dox
+++ b/doc/TopicLinearAlgebraDecompositions.dox
@@ -197,18 +197,6 @@ namespace Eigen {
<td>-</td>
</tr>
- <tr>
- <td>UpperBidiagonalization</td>
- <td>Rows >= columns</td>
- <td>Fast</td>
- <td>Good</td>
- <td>-</td>
- <td>-</td>
- <td>-</td>
- <td>Good</td>
- <td>-</td>
- </tr>
-
<tr class="alt">
<td>Tridiagonalization</td>
<td>Self-adjoint</td>
diff --git a/test/upperbidiagonalization.cpp b/test/upperbidiagonalization.cpp
index ea8057dad..86ec7132b 100644
--- a/test/upperbidiagonalization.cpp
+++ b/test/upperbidiagonalization.cpp
@@ -34,7 +34,7 @@ template<typename MatrixType> void upperbidiag(const MatrixType& m)
typedef Matrix<typename MatrixType::RealScalar, MatrixType::RowsAtCompileTime, MatrixType::ColsAtCompileTime> RealMatrixType;
MatrixType a = MatrixType::Random(rows,cols);
- UpperBidiagonalization<MatrixType> ubd(a);
+ internal::UpperBidiagonalization<MatrixType> ubd(a);
RealMatrixType b(rows, cols);
b.setZero();
b.block(0,0,cols,cols) = ubd.bidiagonal();