aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Merge remote branch 'rbrito/fixes'Gravatar Alex Bennee2011-03-28
|\
| * cddb: avoid calling strlen many times in just a few statements.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As strlen is a potentially costly function, it is better if we make a frugal use of it. To really make things cleaner here, we should replace all the `\n` or `\r` with null chars (i.e., `\0`) in just one go. This would reduce the complexity of the code from something quadratic to something linear in the length of the string. While we are at it, `fgets` does not return `EOF` (`fgetc` does, but `fgets` doesn't) when the end of file is reached and nothing can be read: it returns `NULL` instead.
| * cddb: Plug some memory leaks.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | | | | | | | | | | | Some of these functions are way, way too big and should be split. One obvious low hanging fruit is to use some intelligent goto's to clean up and avoid a bunch of if's in the code, in the very same fashion that is used in the code of the kernel. And, to be honest, using some of the coding style conventions of the kernel here would not hurt at all.
| * cddb: Eliminate unused variable.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | Like this one, the code is full of variables that are defined, but not used and the code can be simplified.
| * Remove executable bits from files that are not scripts/executables.Gravatar Rogério Brito2011-03-08
| |
* | Stop accidental free of referenced FLAC vendor stringGravatar Patrick C. McGinty2011-03-08
|/ | | | | | | | | | The libFLAC API is unclear about how it handles empty strings. The original code assumed that empty string would be copied, when 'copy' param of set_vendor_string was true, as indicated in the API docs. Checking into the libFLAC source, when a string of length 0 is provided, it will NOT be copied. Therfore, free'ing empty string will cause a SIGSEGV or worse when the FLAC API tries to read the vendor string.
* Merge remote branch 'oldmanuk/ubuntu-patches' into new_masterGravatar Alex Bennee2010-11-10
|\
* | [patch] Base64 Decoding Major Performance Fix - ID: 2805834Gravatar Kip Warner2010-11-04
| | | | | | | | | | | | | | | | | | I've patched src/base64.c. There was a major problem when it was being called to decode very large buffers in orders of magnitude of a megabyte or more (e.g. cover art in a FLAC / Vorbis / etc. tag is frequently this size for some people). The base64_decode() routine had a cubic running time, since every time the decode pointer shifted forward in the stream, token_decode() would recompute the buffer length every time.
| * Remove checked-in build scripts that are auto-generated from autogen.Gravatar Dominic Evans2010-11-03
| |
| * [patch] debian/patches/02-autoreconf.patchGravatar Dominic Evans2010-11-03
| | | | | | | | Get rid of binary-or-shlib-defines-rpath lintian warning.
| * [patch] debian/patches/01-autoload.patchGravatar Dominic Evans2010-11-03
|/ | | | | | | Fix the bug that easytag doesn't load the chosen directory when opening easytag from the "open with ..." nautilus right click menu. Ubuntu: https://bugs.launchpad.net/bugs/230873
* Applied Gentoo cddb patchGravatar Alex Bennee2010-07-14
|
* Applied Gentoo new_libmp4v2 patchGravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.6Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.5Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.4Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.3Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.2Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.1Gravatar Alex Bennee2010-07-14