From a54e26601aec191bb8b3ec7790c4b07983363052 Mon Sep 17 00:00:00 2001
From: Adam Chlipala <adam@chlipala.net>
Date: Sun, 13 May 2012 17:41:21 -0400
Subject: Lance Hepler's fix to configure.ac; small refactor of fastcgi.c to
 avoid undefined behavior

---
 src/c/fastcgi.c | 36 ++++++++++++++++--------------------
 1 file changed, 16 insertions(+), 20 deletions(-)

(limited to 'src/c/fastcgi.c')

diff --git a/src/c/fastcgi.c b/src/c/fastcgi.c
index 34042262..5677af83 100644
--- a/src/c/fastcgi.c
+++ b/src/c/fastcgi.c
@@ -40,7 +40,7 @@ typedef struct {
 } FCGI_Output;
 
 typedef struct {
-  char buf[sizeof(FCGI_Record) + 255];
+  FCGI_Record r;
   int available, used, sock;
 } FCGI_Input;
 
@@ -76,32 +76,28 @@ static int fastcgi_send(FCGI_Output *o,
   return uw_really_send(o->sock, &o->r, sizeof(o->r) - 65535 + contentLength);
 }
 
-#define LATEST(i) ((FCGI_Record *)(i->buf + i->used))
-
 static FCGI_Record *fastcgi_recv(FCGI_Input *i) {
+  if (i->used > 0) {
+    memmove((void*)&i->r, (void*)&i->r + i->used, i->available - i->used);
+    i->available -= i->used;
+    i->used = 0;
+  }
+
   while (1) {
     ssize_t n;
 
-    if (i->available >= i->used + sizeof(FCGI_Record) - 65535
-        && i->available >= i->used + sizeof(FCGI_Record) - 65535
-        + ((LATEST(i)->contentLengthB1 << 8) | LATEST(i)->contentLengthB0)
-        + LATEST(i)->paddingLength) {
-      FCGI_Record *r = LATEST(i);
-
-      i->used += sizeof(FCGI_Record) - 65535
-        + ((LATEST(i)->contentLengthB1 << 8) | LATEST(i)->contentLengthB0)
-        + LATEST(i)->paddingLength;
+    if (i->available >= sizeof(FCGI_Record) - 65535
+        && i->available >= sizeof(FCGI_Record) - 65535
+        + ((i->r.contentLengthB1 << 8) | i->r.contentLengthB0)
+        + i->r.paddingLength) {
+      i->used = sizeof(FCGI_Record) - 65535
+        + ((i->r.contentLengthB1 << 8) | i->r.contentLengthB0)
+        + i->r.paddingLength;
       
-      return r;
-    }
-
-    if (i->used > 0) {
-      memmove(i->buf, i->buf + i->used, i->available - i->used);
-      i->available -= i->used;
-      i->used = 0;
+      return &i->r;
     }
 
-    n = recv(i->sock, i->buf + i->available, sizeof(i->buf) - i->available, 0);
+    n = recv(i->sock, (void*)&i->r + i->available, sizeof(i->r) - i->available, 0);
 
     if (n <= 0)
       return NULL;
-- 
cgit v1.2.3