From 189a7111324b5076d2414a83d237f41156d95e2f Mon Sep 17 00:00:00 2001 From: Alan Fitton Date: Mon, 13 Aug 2012 07:23:52 +0100 Subject: fix a possible and rare NULL ptr dereference in an abrt crash report I got, run GTK init before converting command line arguments to hopefully avoid GTK/glib debugging flags being passed as torrent filenames. --- src/trg-gtk-app.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src/trg-gtk-app.c') diff --git a/src/trg-gtk-app.c b/src/trg-gtk-app.c index afc07be..e0ddcf2 100644 --- a/src/trg-gtk-app.c +++ b/src/trg-gtk-app.c @@ -99,8 +99,14 @@ trg_gtk_app_command_line(GApplication * application, { GList *windows = gtk_application_get_windows(GTK_APPLICATION(application)); - TrgMainWindow *window = TRG_MAIN_WINDOW(windows->data); - gchar **argv = g_application_command_line_get_arguments(cmdline, NULL); + TrgMainWindow *window; + gchar **argv; + + if (!windows || !windows->data) + return 1; + + window = TRG_MAIN_WINDOW(windows->data); + argv = g_application_command_line_get_arguments(cmdline, NULL); if (g_application_command_line_get_is_remote(cmdline)) { if (!argv[0]) { -- cgit v1.2.3