From 719d2c04a005714b3a1a1e838ffc653d65da662b Mon Sep 17 00:00:00 2001
From: xleroy <xleroy@fca1b0fc-160b-0410-b1d3-a4f43f01ea2e>
Date: Fri, 20 Sep 2013 13:17:50 +0000
Subject: Small improvements in compilation times for the register allocation
 pass. Maps.v: add a PTree.fold1 operation that doesn't maintain the key.

git-svn-id: https://yquem.inria.fr/compcert/svn/compcert/trunk@2329 fca1b0fc-160b-0410-b1d3-a4f43f01ea2e
---
 backend/Regalloc.ml  |  8 ++++----
 backend/Splitting.ml | 33 ++++++++++++++++++---------------
 backend/XTL.ml       |  4 ++--
 3 files changed, 24 insertions(+), 21 deletions(-)

(limited to 'backend')

diff --git a/backend/Regalloc.ml b/backend/Regalloc.ml
index b73cbf5..3c56b43 100644
--- a/backend/Regalloc.ml
+++ b/backend/Regalloc.ml
@@ -424,8 +424,8 @@ let spill_costs f =
 
   let charge_block blk = List.iter charge_instr blk in
 
-  PTree.fold
-    (fun () pc blk -> charge_block blk)
+  PTree.fold1
+    (fun () blk -> charge_block blk)
     f.fn_code ();
   if !option_dalloctrace then begin
     fprintf !pp "------------------ Unspillable variables --------------@ @.";
@@ -615,8 +615,8 @@ let rec tospill_block alloc blk ts =
   | instr :: blk' -> tospill_block alloc blk' (tospill_instr alloc instr ts)
 
 let tospill_function f alloc =
-  PTree.fold
-    (fun ts pc blk -> tospill_block alloc blk ts)
+  PTree.fold1
+    (fun ts blk -> tospill_block alloc blk ts)
     f.fn_code VSet.empty
 
 
diff --git a/backend/Splitting.ml b/backend/Splitting.ml
index 85de636..b238cef 100644
--- a/backend/Splitting.ml
+++ b/backend/Splitting.ml
@@ -65,22 +65,24 @@ let reg_for lr =
    a live range to the reg if it is live, and no live range if it
    is dead. *)
 
+module RMap = Map.Make(P)
+
 module LRMap = struct
 
-  type t = live_range PTree.t   (* live register -> live range *)
+  type t = live_range RMap.t   (* live register -> live range *)
 
-  let beq m1 m2 = PTree.beq same_range m1 m2
+  let beq m1 m2 = RMap.equal same_range m1 m2
 
-  let bot : t = PTree.empty
+  let bot : t = RMap.empty
 
-  let lub_opt_range olr1 olr2 =
+  let lub_opt_range r olr1 olr2 =
     match olr1, olr2 with
     | Some lr1, Some lr2 -> unify lr1 lr2; olr1
     | Some _, None -> olr1
     | None, _ -> olr2
 
   let lub m1 m2 =
-    PTree.combine lub_opt_range m1 m2
+    RMap.merge lub_opt_range m1 m2
 
 end
 
@@ -89,11 +91,11 @@ module Solver = Backward_Dataflow_Solver(LRMap)(NodeSetBackward)
 (* A cache of live ranges associated to (pc, used reg) pairs. *)
 
 let live_range_cache =
-  (Hashtbl.create 123 : (int32 * int32, live_range) Hashtbl.t)
+  (Hashtbl.create 123 : (int * int, live_range) Hashtbl.t)
 
 let live_range_for pc r =
-  let pc' = P.to_int32 pc
-  and r' = P.to_int32 r in
+  let pc' = P.to_int pc
+  and r' = P.to_int r in
   try
     Hashtbl.find live_range_cache (pc',r')
   with Not_found ->
@@ -104,14 +106,14 @@ let live_range_for pc r =
 (* The transfer function *)
 
 let reg_live pc r map =
-  match PTree.get r map with
-  | Some lr -> map                                     (* already live *)
-  | None    -> PTree.set r (live_range_for pc r) map   (* becomes live *)
+  if RMap.mem r map
+  then map                                    (* already live *)
+  else RMap.add r (live_range_for pc r) map   (* becomes live *)
 
 let reg_list_live pc rl map = List.fold_right (reg_live pc) rl map
 
 let reg_dead r map =
-  PTree.remove r map
+  RMap.remove r map
 
 let transfer f pc after =
   match PTree.get pc f.fn_code with
@@ -131,9 +133,10 @@ let analysis f = Solver.fixpoint f.fn_code successors_instr (transfer f) []
 (* Produce renamed registers for each instruction. *)
 
 let ren_reg map r =
-  match PTree.get r map with
-  | Some lr -> reg_for lr
-  | None -> XTL.new_reg()
+  try
+    reg_for (RMap.find r map)
+  with Not_found ->
+    XTL.new_reg()
 
 let ren_regs map rl =
   List.map (ren_reg map) rl
diff --git a/backend/XTL.ml b/backend/XTL.ml
index 53c478d..46c59b0 100644
--- a/backend/XTL.ml
+++ b/backend/XTL.ml
@@ -176,9 +176,9 @@ let type_function f =
 let basic_blocks_map f = (* return mapping pc -> number of predecessors *)
   let add_successor map s =
     PMap.set s (1 + PMap.get s map) map in
-  let add_successors_block map pc blk =
+  let add_successors_block map blk =
     List.fold_left add_successor map (successors_block blk) in
-  PTree.fold add_successors_block f.fn_code
+  PTree.fold1 add_successors_block f.fn_code
     (PMap.set f.fn_entrypoint 2 (PMap.init 0))
 
 let transform_basic_blocks
-- 
cgit v1.2.3