From d4cf6b71af0960eeacf45f9b3c7d5d713d52e3b1 Mon Sep 17 00:00:00 2001 From: Chris Mihelich Date: Thu, 27 Jun 2024 12:58:13 -0700 Subject: Declare Rust demangling feature-complete. PiperOrigin-RevId: 647417773 Change-Id: I7d945ae27199262b3baf83b232d17c2f641a27ac --- absl/debugging/internal/demangle.h | 3 ++- absl/debugging/internal/demangle_rust.h | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'absl') diff --git a/absl/debugging/internal/demangle.h b/absl/debugging/internal/demangle.h index e75d1473..cb0aba13 100644 --- a/absl/debugging/internal/demangle.h +++ b/absl/debugging/internal/demangle.h @@ -56,7 +56,8 @@ namespace debugging_internal { // // See the unit test for more examples. // -// Support for Rust mangled names is in development; see demangle_rust.h. +// Demangle also recognizes Rust mangled names by delegating the parsing of +// anything that starts with _R to DemangleRustSymbolEncoding (demangle_rust.h). // // Note: we might want to write demanglers for ABIs other than Itanium // C++ ABI in the future. diff --git a/absl/debugging/internal/demangle_rust.h b/absl/debugging/internal/demangle_rust.h index 29e08ecd..94a9aecb 100644 --- a/absl/debugging/internal/demangle_rust.h +++ b/absl/debugging/internal/demangle_rust.h @@ -32,9 +32,6 @@ namespace debugging_internal { // DemangleRustSymbolEncoding is async-signal-safe and runs in bounded C++ // call-stack space. It is suitable for symbolizing stack traces in a signal // handler. -// -// The demangling logic is under development; search for "not yet implemented" -// in the .cc file to see where the gaps are. bool DemangleRustSymbolEncoding(const char* mangled, char* out, size_t out_size); -- cgit v1.2.3