From e92505d8d6bf50c5d44805eb5fe73e9f56484cf4 Mon Sep 17 00:00:00 2001 From: Dino Radakovic Date: Tue, 17 May 2022 15:21:04 -0700 Subject: Use NullSafeStringView for const char* args to absl::StrCat, treating null pointers as "" Fixes #1167 PiperOrigin-RevId: 449328725 Change-Id: I813785db77b94efa49eeeff4c93449334c380935 --- absl/strings/str_cat_test.cc | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'absl/strings/str_cat_test.cc') diff --git a/absl/strings/str_cat_test.cc b/absl/strings/str_cat_test.cc index f3770dc0..69df2502 100644 --- a/absl/strings/str_cat_test.cc +++ b/absl/strings/str_cat_test.cc @@ -210,6 +210,11 @@ TEST(StrCat, CornerCases) { EXPECT_EQ(result, ""); } +TEST(StrCat, NullConstCharPtr) { + const char* null = nullptr; + EXPECT_EQ(absl::StrCat("mon", null, "key"), "monkey"); +} + // A minimal allocator that uses malloc(). template struct Mallocator { -- cgit v1.2.3