From 6b2d248d3e9fb5f07ea4a65a6d0923726854d446 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Mon, 17 Oct 2022 13:53:40 -0700 Subject: Disables StderrKnobsDefault due to order dependency The SetLogtostderr and SetAlsologtostderr tests are setting flags that cause the stderrthreshold global value to be out of sync with the stderrthreshold flag. As a result, it is not currently possible to remove order dependency with these existing tests. PiperOrigin-RevId: 481731395 Change-Id: Ie992520982f2e69821d1d1b660e3326bf745ef0d --- absl/log/flags_test.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'absl/log') diff --git a/absl/log/flags_test.cc b/absl/log/flags_test.cc index 7a803152..a0f6d763 100644 --- a/absl/log/flags_test.cc +++ b/absl/log/flags_test.cc @@ -48,7 +48,10 @@ class LogFlagsTest : public ::testing::Test { absl::FlagSaver flag_saver_; }; -TEST_F(LogFlagsTest, StderrKnobsDefault) { +// This test is disabled because it adds order dependency to the test suite. +// This order dependency is currently not fixable due to the way the +// stderrthreshold global value is out of sync with the stderrthreshold flag. +TEST_F(LogFlagsTest, DISABLED_StderrKnobsDefault) { EXPECT_EQ(absl::StderrThreshold(), DefaultStderrThreshold()); } -- cgit v1.2.3