summaryrefslogtreecommitdiff
path: root/absl/strings
diff options
context:
space:
mode:
Diffstat (limited to 'absl/strings')
-rw-r--r--absl/strings/internal/str_format/checker.h4
-rw-r--r--absl/strings/str_format_test.cc2
2 files changed, 4 insertions, 2 deletions
diff --git a/absl/strings/internal/str_format/checker.h b/absl/strings/internal/str_format/checker.h
index 2542f31d..aeb9d48d 100644
--- a/absl/strings/internal/str_format/checker.h
+++ b/absl/strings/internal/str_format/checker.h
@@ -212,6 +212,10 @@ class ConvParser {
constexpr ConvParser ParseConversion() const {
char first_char = GetChar(format_, 0);
+ if (first_char == 'v' && *(format_.data() - 1) != '%') {
+ return SetError(true);
+ }
+
if (is_positional_) {
return VerifyPositional({ConsumeFront(format_), arg_position_},
first_char);
diff --git a/absl/strings/str_format_test.cc b/absl/strings/str_format_test.cc
index 7bffbb7a..4ac6aa27 100644
--- a/absl/strings/str_format_test.cc
+++ b/absl/strings/str_format_test.cc
@@ -291,8 +291,6 @@ TEST_F(FormatEntryPointTest, FormatStreamed) {
TEST_F(FormatEntryPointTest, FormatStreamedWithV) {
EXPECT_EQ("123", StrFormat("%v", FormatStreamed(123)));
- EXPECT_EQ(" 123", StrFormat("%5v", FormatStreamed(123)));
- EXPECT_EQ("123 ", StrFormat("%-5v", FormatStreamed(123)));
EXPECT_EQ("X", StrFormat("%v", FormatStreamed(streamed_test::X())));
EXPECT_EQ("123", StrFormat("%v", FormatStreamed(StreamFormat("%d", 123))));
}