diff options
| author |  Mike Kruskal <mkruskal@google.com> | 2022-12-13 15:11:53 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-worker@google.com> | 2022-12-13 15:12:32 -0800 |
| commit | a13ef44bf3f2ef5399c6fc587a18f3b203b4d37a (patch) | |
| tree | 1258c8f13a9791708c62cc70c787e69db4a51775 /absl/log/BUILD.bazel | |
| parent | 4cb6c3893638348ef261716ac47ede4f5f88b8e9 (diff) | |
Prevent all CHECK functions from expanding macros for the error string.
This was likely an unintentional behavior change made a while ago while trying to reduce duplication. The new behavior will always include the unexpanded macro in the error string. For example, `CHECK_EQ(MACRO(x), MACRO(y))` will now output "MACRO(x) == MACRO(y)" if it fails. Before this change, CHECK and QCHECK were the only macros that had this behavior.
Not using function-like macro aliases is a possible alternative here, but unfortunately that would flood the macro namespace downstream with CHECK* and break existing code.
PiperOrigin-RevId: 495138582
Change-Id: I6a1afd89a6b9334003362e5d3e55da68f86eec98
Diffstat (limited to 'absl/log/BUILD.bazel')
| -rw-r--r-- | absl/log/BUILD.bazel | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/absl/log/BUILD.bazel b/absl/log/BUILD.bazel index a420f21a..10916446 100644 --- a/absl/log/BUILD.bazel +++ b/absl/log/BUILD.bazel @@ -294,6 +294,7 @@ cc_library( "//absl/base:config", "//absl/base:core_headers", "//absl/log/internal:test_helpers", + "//absl/status", "@com_google_googletest//:gtest", ], ) |