diff options
author | Abseil Team <absl-team@google.com> | 2020-10-26 09:50:44 -0700 |
---|---|---|
committer | vslashg <gfalcon@google.com> | 2020-10-26 16:18:57 -0400 |
commit | 5bf048b8425cc0a342e4647932de19e25ffd6ad7 (patch) | |
tree | 230a48e04f01169f632ee13b4f6c7e218b5cc177 /absl/copts | |
parent | 1e3d25b2657228bd691ee938cfd37d487f48054b (diff) |
Export of internal Abseil changes
--
730bb88bee556aa11fa19aa33e1434cb6fa78985 by Evan Brown <ezb@google.com>:
Support missing allocator-related constructors in b-tree. See [reference](https://en.cppreference.com/w/cpp/container/set/set).
Also use allocator_traits::select_on_container_copy_construction() to get allocator for copy construction.
PiperOrigin-RevId: 339058322
--
b6cc121689ae3e452d1db2d66122cb198d25142b by Derek Mauro <dmauro@google.com>:
Fix more sign-compare warnings
PiperOrigin-RevId: 339057920
--
0e2c62da1dcaf6529abab952bdcc96c6de2d9506 by Abseil Team <absl-team@google.com>:
Add missing <limits> include
PiperOrigin-RevId: 339054753
--
d5a9ec2d1e40fe6359e720942e4955009ee415ec by Derek Mauro <dmauro@google.com>:
Stop disabling sign-compare warnings for non-test targets.
Our users complain about these.
This does not catch issues in header-only libraries (like btree.h)
but we may work on those in the future
PiperOrigin-RevId: 338967089
--
0c062c542a4c61ea0f65d25811827c0858e3adde by Abseil Team <absl-team@google.com>:
Improve cache-locality for ThreadIdentity and PerThreadSynch.
This is a change based on an observation in RPC benchmarks that shows
significant cycles being spent in waking up a thread, 99.8% of which
was on cache misses. Investigating this a bit more, it turns out to
be due to sharing the cache line with the waiter state.
To fix this issue, the following changes are introduced:
- Reorder fields in PerThreadSync so that it fits in a single cache line
The size of this structure was 80 bytes before this change.
Note: Manually inspected all booleans to make sure they are not modified by
multiple threads concurrently.
PiperOrigin-RevId: 338852058
--
a90d6f2b2346385017e32dd8ae1b5ca691a5863f by Derek Mauro <dmauro@google.com>:
Delete GCC 4.9 test script. It is no longer supported
PiperOrigin-RevId: 338779452
--
7274008d4757e88869110be9db39d03d911ae2b5 by Abseil Team <absl-team@google.com>:
Fix the usage example in which SetFlag should take a pointer.
PiperOrigin-RevId: 338744529
GitOrigin-RevId: 730bb88bee556aa11fa19aa33e1434cb6fa78985
Change-Id: Iff99594c4022e60e482a392d334b376c7ae8883e
Diffstat (limited to 'absl/copts')
-rw-r--r-- | absl/copts/GENERATED_AbseilCopts.cmake | 3 | ||||
-rw-r--r-- | absl/copts/GENERATED_copts.bzl | 3 | ||||
-rw-r--r-- | absl/copts/copts.py | 7 |
3 files changed, 0 insertions, 13 deletions
diff --git a/absl/copts/GENERATED_AbseilCopts.cmake b/absl/copts/GENERATED_AbseilCopts.cmake index 97bd283e..beb3799e 100644 --- a/absl/copts/GENERATED_AbseilCopts.cmake +++ b/absl/copts/GENERATED_AbseilCopts.cmake @@ -16,7 +16,6 @@ list(APPEND ABSL_CLANG_CL_FLAGS "-Wno-extra-semi-stmt" "-Wno-packed" "-Wno-padded" - "-Wno-sign-compare" "-Wno-float-conversion" "-Wno-float-equal" "-Wno-format-nonliteral" @@ -88,7 +87,6 @@ list(APPEND ABSL_GCC_FLAGS "-Wvla" "-Wwrite-strings" "-Wno-missing-field-initializers" - "-Wno-sign-compare" "-DNOMINMAX" ) @@ -117,7 +115,6 @@ list(APPEND ABSL_LLVM_FLAGS "-Wno-extra-semi-stmt" "-Wno-packed" "-Wno-padded" - "-Wno-sign-compare" "-Wno-float-conversion" "-Wno-float-equal" "-Wno-format-nonliteral" diff --git a/absl/copts/GENERATED_copts.bzl b/absl/copts/GENERATED_copts.bzl index bcdd61ef..ff729d74 100644 --- a/absl/copts/GENERATED_copts.bzl +++ b/absl/copts/GENERATED_copts.bzl @@ -17,7 +17,6 @@ ABSL_CLANG_CL_FLAGS = [ "-Wno-extra-semi-stmt", "-Wno-packed", "-Wno-padded", - "-Wno-sign-compare", "-Wno-float-conversion", "-Wno-float-equal", "-Wno-format-nonliteral", @@ -89,7 +88,6 @@ ABSL_GCC_FLAGS = [ "-Wvla", "-Wwrite-strings", "-Wno-missing-field-initializers", - "-Wno-sign-compare", "-DNOMINMAX", ] @@ -118,7 +116,6 @@ ABSL_LLVM_FLAGS = [ "-Wno-extra-semi-stmt", "-Wno-packed", "-Wno-padded", - "-Wno-sign-compare", "-Wno-float-conversion", "-Wno-float-equal", "-Wno-format-nonliteral", diff --git a/absl/copts/copts.py b/absl/copts/copts.py index a3437c1b..55b5fb10 100644 --- a/absl/copts/copts.py +++ b/absl/copts/copts.py @@ -41,10 +41,6 @@ LLVM_DISABLE_WARNINGS_FLAGS = [ "-Wno-packed", "-Wno-padded", ### - # Google style does not use unsigned integers, though STL containers - # have unsigned types. - "-Wno-sign-compare", - ### "-Wno-float-conversion", "-Wno-float-equal", "-Wno-format-nonliteral", @@ -138,9 +134,6 @@ COPT_VARS = { # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36750 # Remove when gcc-4.x is no longer supported. "-Wno-missing-field-initializers", - # Google style does not use unsigned integers, though STL containers - # have unsigned types. - "-Wno-sign-compare", # Don't define min and max macros (Build on Windows using gcc) "-DNOMINMAX", ], |