diff options
author | Evan Brown <ezb@google.com> | 2024-02-23 11:33:08 -0800 |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2024-02-23 11:34:48 -0800 |
commit | eef325b1d102aa4cbf1dbd865493ea0757222f3f (patch) | |
tree | ddc5b152b75ac20aed0f82dc638ac844c29f6a9f /absl/container/internal | |
parent | d87dc03cee90a0cac2dbf254217b346ca693bb83 (diff) |
Add braces for conditional statements in raw_hash_map functions.
The current version violates the Google C++ style guide - see https://google.github.io/styleguide/cppguide.html#Formatting_Looping_Branching. This code does not fit into the historical exception that "the curly braces for the controlled statement or the line breaks inside the curly braces may be omitted if as a result the entire statement appears on either a single line (in which case there is a space between the closing parenthesis and the controlled statement) or on two lines (in which case there is a line break after the closing parenthesis and there are no braces)."
PiperOrigin-RevId: 609789188
Change-Id: Id7ae9596e454dac5581d19939564c07670077f92
Diffstat (limited to 'absl/container/internal')
-rw-r--r-- | absl/container/internal/raw_hash_map.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/absl/container/internal/raw_hash_map.h b/absl/container/internal/raw_hash_map.h index 64dcd3d4..464bf23b 100644 --- a/absl/container/internal/raw_hash_map.h +++ b/absl/container/internal/raw_hash_map.h @@ -198,10 +198,11 @@ class raw_hash_map : public raw_hash_set<Policy, Hash, Eq, Alloc> { std::pair<iterator, bool> insert_or_assign_impl(K&& k, V&& v) ABSL_ATTRIBUTE_LIFETIME_BOUND { auto res = this->find_or_prepare_insert(k); - if (res.second) + if (res.second) { this->emplace_at(res.first, std::forward<K>(k), std::forward<V>(v)); - else + } else { Policy::value(&*res.first) = std::forward<V>(v); + } return res; } @@ -209,10 +210,11 @@ class raw_hash_map : public raw_hash_set<Policy, Hash, Eq, Alloc> { std::pair<iterator, bool> try_emplace_impl(K&& k, Args&&... args) ABSL_ATTRIBUTE_LIFETIME_BOUND { auto res = this->find_or_prepare_insert(k); - if (res.second) + if (res.second) { this->emplace_at(res.first, std::piecewise_construct, std::forward_as_tuple(std::forward<K>(k)), std::forward_as_tuple(std::forward<Args>(args)...)); + } return res; } }; |