diff options
| author |  Dmitry Vyukov <dvyukov@google.com> | 2023-10-18 22:19:06 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-worker@google.com> | 2023-10-18 22:19:45 -0700 |
| commit | 03786143361db9d8581cb02ed1c5027d732b62fc (patch) | |
| tree | 9648c84be16fee40fb8403b30ba296d785475b28 /absl/base | |
| parent | 9687a8ea750bfcddf790372093245a1d041b21a3 (diff) | |
Optimize prefetch codegen.
Currently we use "r" constraint to pass prefetched address.
This forces the compiler to actually put it into a register.
As the result some uses look as:
16bfb7c: 48 01 cf add %rcx,%rdi
16bfb7f: 0f 0d 0f prefetchw (%rdi)
--
16bfccf: 48 83 c1 60 add $0x60,%rcx
16bfcd3: 0f 0d 09 prefetchw (%rcx)
Use "m" constraint instead. It's more relaxed and requires
to just materialize the address in some form using whatever
addressing modes the target supports (e.g. x86 off(base, index, scale)).
With the change the same code becomes:
16bfb7c: 0f 0d 0c 39 prefetchw (%rcx,%rdi,1)
--
16bfccf: 0f 0d 49 60 prefetchw 0x60(%rcx)
PiperOrigin-RevId: 574723975
Change-Id: Id0c8645f8c702d1842685343901da321f6513156
Diffstat (limited to 'absl/base')
| -rw-r--r-- | absl/base/prefetch.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/absl/base/prefetch.h b/absl/base/prefetch.h index 6fd2a820..609e26e7 100644 --- a/absl/base/prefetch.h +++ b/absl/base/prefetch.h @@ -158,7 +158,7 @@ ABSL_ATTRIBUTE_ALWAYS_INLINE inline void PrefetchToLocalCacheForWrite( // manually emit prefetchw. PREFETCHW is recognized as a no-op on older Intel // processors and has been present on AMD processors since the K6-2. #if defined(__x86_64__) - asm("prefetchw (%0)" : : "r"(addr)); + asm("prefetchw %0" : : "m"(*reinterpret_cast<const char*>(addr))); #else __builtin_prefetch(addr, 1, 3); #endif @@ -187,7 +187,7 @@ ABSL_ATTRIBUTE_ALWAYS_INLINE inline void PrefetchToLocalCacheForWrite( // up, PREFETCHW is recognized as a no-op on older Intel processors // and has been present on AMD processors since the K6-2. We have this // disabled for MSVC compilers as this miscompiles on older MSVC compilers. - asm("prefetchw (%0)" : : "r"(addr)); + asm("prefetchw %0" : : "m"(*reinterpret_cast<const char*>(addr))); #endif } |