diff options
| author |  Abseil Team <absl-team@google.com> | 2021-02-10 18:47:04 -0800 |
|---|---|---|
| committer |  Derek Mauro <dmauro@google.com> | 2021-02-11 13:57:23 -0500 |
| commit | b343ac3a649f5713380cdbeee79d2ee6f94ddd93 (patch) | |
| tree | 4afd03fb6f57eb493617476218dc77edc8368b6e | |
| parent | 1d1ad2292bb5c7be26074e516b4cc70d9cc469f9 (diff) | |
Export of internal Abseil changes
--
684e488495a2d95def9a865569ad5ba7ec89967f by Abseil Team <absl-team@google.com>:
Remove references to deleted clang-tidy checks.
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:356861384:BASE:356825575:1613005412689:548d66bd
PiperOrigin-RevId: 356877726
--
f9d8549cd67866e13bb71b21280ec293684ab43b by Abseil Team <absl-team@google.com>:
Add missing closing punctuation to two file-level comments.
PiperOrigin-RevId: 356867260
GitOrigin-RevId: 684e488495a2d95def9a865569ad5ba7ec89967f
Change-Id: Ibe04878684c20a23b214ee7e5df9c6dd434bc3dc
| -rw-r--r-- | absl/flags/marshalling.h | 4 | ||||
| -rw-r--r-- | absl/random/internal/mock_overload_set.h | 12 |
2 files changed, 7 insertions, 9 deletions
diff --git a/absl/flags/marshalling.h b/absl/flags/marshalling.h index 0b503354..7cbc136d 100644 --- a/absl/flags/marshalling.h +++ b/absl/flags/marshalling.h @@ -83,7 +83,7 @@ // // AbslParseFlag converts from a string to OutputMode. // // Must be in same namespace as OutputMode. // -// // Parses an OutputMode from the command line flag value `text. Returns +// // Parses an OutputMode from the command line flag value `text`. Returns // // `true` and sets `*mode` on success; returns `false` and sets `*error` // // on failure. // bool AbslParseFlag(absl::string_view text, @@ -139,7 +139,7 @@ // // // Within the implementation, `AbslParseFlag()` will, in turn invoke // // `absl::ParseFlag()` on its constituent `int` and `std::string` types -// // (which have built-in Abseil flag support. +// // (which have built-in Abseil flag support). // // bool AbslParseFlag(absl::string_view text, MyFlagType* flag, // std::string* err) { diff --git a/absl/random/internal/mock_overload_set.h b/absl/random/internal/mock_overload_set.h index dccc6cee..c5ce3588 100644 --- a/absl/random/internal/mock_overload_set.h +++ b/absl/random/internal/mock_overload_set.h @@ -45,9 +45,8 @@ struct MockSingleOverload<DistrT, Ret(MockingBitGen&, Args...)> { "Overload signature must have return type matching the " "distribution result_type."); using KeyT = Ret(DistrT, std::tuple<Args...>); - auto gmock_Call( - absl::MockingBitGen& gen, // NOLINT(google-runtime-references) - const ::testing::Matcher<Args>&... matchers) + auto gmock_Call(absl::MockingBitGen& gen, + const ::testing::Matcher<Args>&... matchers) -> decltype(MockHelpers::MockFor<KeyT>(gen).gmock_Call(matchers...)) { return MockHelpers::MockFor<KeyT>(gen).gmock_Call(matchers...); } @@ -59,10 +58,9 @@ struct MockSingleOverload<DistrT, Ret(Arg, MockingBitGen&, Args...)> { "Overload signature must have return type matching the " "distribution result_type."); using KeyT = Ret(DistrT, std::tuple<Arg, Args...>); - auto gmock_Call( - const ::testing::Matcher<Arg>& matcher, - absl::MockingBitGen& gen, // NOLINT(google-runtime-references) - const ::testing::Matcher<Args>&... matchers) + auto gmock_Call(const ::testing::Matcher<Arg>& matcher, + absl::MockingBitGen& gen, + const ::testing::Matcher<Args>&... matchers) -> decltype(MockHelpers::MockFor<KeyT>(gen).gmock_Call(matcher, matchers...)) { return MockHelpers::MockFor<KeyT>(gen).gmock_Call(matcher, matchers...); |