diff options
| author |  Dino Radakovic <dinor@google.com> | 2024-04-17 07:44:51 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-worker@google.com> | 2024-04-17 07:45:51 -0700 |
| commit | fa57bfc573453d57a38552eedcce894b0e2d9f5e (patch) | |
| tree | 292a4e2d3d504a05518be01d15e3c4409e4783dc | |
| parent | e304ff50c379835eb36c509556ff8cc4321b451e (diff) | |
`absl/log/internal`: Document conditional ABSL_ATTRIBUTE_UNUSED, add C++17 TODO
Once absl's support floor moves to C++17, we'll be able to replace it with [`[[maybe_unused]]`](https://en.cppreference.com/w/cpp/language/attributes/maybe_unused).
PiperOrigin-RevId: 625680108
Change-Id: I823b70c0f833dcf9c41bca0c2566b12ec65785de
| -rw-r--r-- | absl/log/internal/strip.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/absl/log/internal/strip.h b/absl/log/internal/strip.h index ee7f296c..3e550104 100644 --- a/absl/log/internal/strip.h +++ b/absl/log/internal/strip.h @@ -31,6 +31,13 @@ // logging in subtly different ways for subtly different reasons (see below). #if defined(STRIP_LOG) && STRIP_LOG +// Attribute for marking variables used in implementation details of logging +// macros as unused, but only when `STRIP_LOG` is defined. +// With `STRIP_LOG` on, not marking them triggers `-Wunused-but-set-variable`, +// With `STRIP_LOG` off, marking them triggers `-Wused-but-marked-unused`. +// +// TODO(b/290784225): Replace this macro with attribute [[maybe_unused]] when +// Abseil stops supporting C++14. #define ABSL_LOG_INTERNAL_ATTRIBUTE_UNUSED_IF_STRIP_LOG ABSL_ATTRIBUTE_UNUSED #define ABSL_LOGGING_INTERNAL_LOG_INFO ::absl::log_internal::NullStream() |