diff options
| author |  Loo Rong Jie <loorongjie@gmail.com> | 2017-11-29 08:37:53 +0800 |
|---|---|---|
| committer | Loo Rong Jie <loorongjie@gmail.com> | 2017-11-29 08:37:53 +0800 |
| commit | e98380282fdcd1573d478f380dafa08a15d2f9a5 (patch) | |
| tree | 2b62c1629a0c3e636ac905ba7cbcc9ae71cf53c9 | |
| parent | 79ae60ed9737f6c0ec652eab5492b1359aaea9cf (diff) | |
Add comments about warning flags
| -rw-r--r-- | CMake/README.md | 5 | ||||
| -rw-r--r-- | CMakeLists.txt | 7 |
2 files changed, 11 insertions, 1 deletions
diff --git a/CMake/README.md b/CMake/README.md index 9c2d6897..0ae9c268 100644 --- a/CMake/README.md +++ b/CMake/README.md @@ -44,6 +44,11 @@ set(CMAKE_CXX_FLAGS "-std=c++11 -stdlib=libc++ ${CMAKE_CXX_FLAGS}") if (MSVC) + # /wd4005 macro-redefinition + # /wd4068 unknown pragma + # /wd4244 conversion from 'type1' to 'type2' + # /wd4267 conversion from 'size_t' to 'type2' + # /wd4800 force value to bool 'true' or 'false' (performance warning) add_compile_options(/wd4005 /wd4068 /wd4244 /wd4267 /wd4800) add_definitions(/DNOMINMAX /DWIN32_LEAN_AND_MEAN=1 /D_CRT_SECURE_NO_WARNINGS) endif() diff --git a/CMakeLists.txt b/CMakeLists.txt index a740088a..c65805eb 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -27,8 +27,13 @@ include(AbseilHelpers) # config options if (MSVC) - add_definitions(/DNOMINMAX /DWIN32_LEAN_AND_MEAN=1 /D_CRT_SECURE_NO_WARNINGS) + # /wd4005 macro-redefinition + # /wd4068 unknown pragma + # /wd4244 conversion from 'type1' to 'type2' + # /wd4267 conversion from 'size_t' to 'type2' + # /wd4800 force value to bool 'true' or 'false' (performance warning) add_compile_options(/W3 /WX /wd4005 /wd4068 /wd4244 /wd4267 /wd4800) + add_definitions(/DNOMINMAX /DWIN32_LEAN_AND_MEAN=1 /D_CRT_SECURE_NO_WARNINGS) else() set(ABSL_STD_CXX_FLAG "-std=c++11" CACHE STRING "c++ std flag (default: c++11)") endif() |