summaryrefslogtreecommitdiff
path: root/.gitignore
diff options
context:
space:
mode:
authorGravatar Loo Rong Jie <loorongjie@gmail.com>2019-03-23 03:23:01 +0800
committerGravatar Derek Mauro <761129+derekmauro@users.noreply.github.com>2019-03-22 15:23:01 -0400
commit253eb7416421661873afbaa33828a850db978541 (patch)
tree0c4bdcdafe4b37af181991063f54113d880c1fdc /.gitignore
parente75672f6afc7e8f23ee7b532e86d1b3b9be3984e (diff)
[CMake] Set correct flags for clang-cl (#278)
clang-cl produce binaries with MSVC ABI and wants to be as flag-compatible with pure MSVC as possible, so this leads to all sorts of weird cases. clang-cl alias /Wall as clang's -Weverything which is way too verbose, so it needs /W3 like pure MSVC. clang-cl only understand GCC style warning flags (-W[no]blah) and just silent drop MSVC style warning flags (/wd[num]). clang-cl needs MSVC define flags since it is consuming the same header files as pure MSVC. CMake set CMAKE_CXX_COMPILER_ID as Clang when clang-cl is detected, so need extra if (MSVC) to differentiate it. We are not doing clang-cl specialization in Bazel as currently there is no reliable way to detect clang-cl in Bazel.. This PR should be NFC for LLVM/GCC users on Unix platforms. Other changes: Add ABSL_ prefix to variable names to avoid name collision in CMake.
Diffstat (limited to '.gitignore')
-rw-r--r--.gitignore2
1 files changed, 1 insertions, 1 deletions
diff --git a/.gitignore b/.gitignore
index 31f33741..d54fa5a9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,5 +11,5 @@ CMakeLists.txt.user
# Ignore VS Code files
.vscode/*
# Ignore generated python artifacts
-copts/copts.pyc
+*.pyc
copts/__pycache__/