From cf265ef5e32f08562db702fb545fb5d346e0e924 Mon Sep 17 00:00:00 2001 From: Tej Chajed Date: Thu, 21 Sep 2017 18:36:00 -0400 Subject: Report missing arguments in error message Augment the "Illegal tactic application" error message with the number of extra arguments passed. Fixes BZ#5753. --- plugins/ltac/tacinterp.ml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'plugins/ltac/tacinterp.ml') diff --git a/plugins/ltac/tacinterp.ml b/plugins/ltac/tacinterp.ml index 8fa95ffb0..3a8526874 100644 --- a/plugins/ltac/tacinterp.ml +++ b/plugins/ltac/tacinterp.ml @@ -1394,7 +1394,13 @@ and interp_app loc ist fv largs : Val.t Ftactic.t = if List.is_empty lval then Ftactic.return v else interp_app loc ist v lval else Ftactic.return (of_tacvalue (VFun(push_appl appl largs,trace,newlfun,lvar,body))) - | _ -> fail + | (VFun(appl,trace,olfun,[],body)) -> + let extra_args = List.length largs in + Tacticals.New.tclZEROMSG (str "Illegal tactic application: got " ++ + str (string_of_int extra_args) ++ + str " extra " ++ str (String.plural extra_args "argument") ++ + str ".") + | VRec(_,_) -> fail else fail (* Gives the tactic corresponding to the tactic value *) -- cgit v1.2.3