aboutsummaryrefslogtreecommitdiffhomepage
path: root/plugins/setoid_ring/newring_plugin.mlpack
diff options
context:
space:
mode:
authorGravatar Emilio Jesus Gallego Arias <e+git@x80.org>2018-02-28 09:43:06 +0100
committerGravatar Maxime Dénès <mail@maximedenes.fr>2018-03-10 10:24:07 +0100
commit99129d2518bd9fe92051aa89138cbb57c839a270 (patch)
treec7185ce535ef7c5438e79f1c4b81464c8367d6c9 /plugins/setoid_ring/newring_plugin.mlpack
parent4d5c7243b4aea5b28358757e2d86c11334da6699 (diff)
[ssreflect] Fix module scoping problems due to packing and mli files.
Unfortunately, mli-only files cannot be included in packs, so we have the weird situation that the scope for `Tacexpr` is wrong. So we cannot address the module as `Ltac_plugin.Tacexpr` but it lives in the global namespace instead. This creates problem when using other modular build/packing strategies [such as #6857] This could be indeed considered a bug in the OCaml compiler. In order to remedy this situation we face two choices: - leave the module out of the pack (!) - create an implementation for the module I chose the second solution as it seems to me like the most sensible choice. cc: #6512.
Diffstat (limited to 'plugins/setoid_ring/newring_plugin.mlpack')
-rw-r--r--plugins/setoid_ring/newring_plugin.mlpack1
1 files changed, 1 insertions, 0 deletions
diff --git a/plugins/setoid_ring/newring_plugin.mlpack b/plugins/setoid_ring/newring_plugin.mlpack
index 23663b409..5aa79b586 100644
--- a/plugins/setoid_ring/newring_plugin.mlpack
+++ b/plugins/setoid_ring/newring_plugin.mlpack
@@ -1,2 +1,3 @@
+Newring_ast
Newring
G_newring